[#MBS-4664] Use of uninitialized value in sprintf at lib/DBDefs.pm line 314. - MusicBrainz JIRA

MusicBrainz Server

Use of uninitialized value in sprintf at lib/DBDefs.pm line 314.

Created: 06/May/12 12:37 PM Updated: 23/May/12 09:41 AM Resolved: 23/May/12 09:10 AM

Component/s:

Admin

Affects Version/s:

None

Fix Version/s:

Bug fixes, 2012-05-28

Description

« Hide

I get this error when running the admin/cron/slave.sh script with the latest checkout (commit 75dc193). I have already removed ./local and ran carton install --deployment successfully...

Sort Order:

[ Permalink | « Hide ]

Johannes Weißl added a comment - 06/May/12 01:04 PM

Seems http://chatlogs.musicbrainz.org/musicbrainz-devel/2012/2012-05/2012-05-02.html#T07-48-49-963493 is related.

[ Permalink | « Hide ]

Oliver Charles added a comment - 08/May/12 10:30 AM

Fixed in fe311bca

Oliver Charles made changes - 08/May/12 10:30 AM

Field	Original Value	New Value
Status	Open [ 1 ]	Closed [ 6 ]
Fix Version/s		Schema change, 2012-05-15 [ 10117 ]
Resolution		Fixed [ 1 ]

[ Permalink | « Hide ]

Johannes Weißl added a comment - 08/May/12 01:28 PM

The error is still there in fe311bc... (but the syntax error in SESSION_STORE_ARGS got fixed, thanks!).

Johannes Weißl made changes - 08/May/12 01:28 PM

Resolution	Fixed [ 1 ]
Status	Closed [ 6 ]	Reopened [ 4 ]

Oliver Charles made changes - 15/May/12 10:28 PM

Fix Version/s		Bug fixes, 2012-05-28 [ 10133 ]
Fix Version/s	Schema change, 2012-05-15 [ 10117 ]

[ Permalink | « Hide ]

Oliver Charles added a comment - 16/May/12 03:36 PM

Fixed in fe311bcae95be66398 and already shipped.

Oliver Charles made changes - 16/May/12 03:36 PM

Status	Reopened [ 4 ]	Closed [ 6 ]
Assignee		Oliver Charles [ acid2 ]
Fix Version/s		Schema change, 2012-05-15 [ 10117 ]
Fix Version/s	Bug fixes, 2012-05-28 [ 10133 ]
Resolution		Fixed [ 1 ]

Johannes Weißl made changes - 20/May/12 02:22 PM

Resolution	Fixed [ 1 ]
Status	Closed [ 6 ]	Reopened [ 4 ]

[ Permalink | « Hide ]

Johannes Weißl added a comment - 20/May/12 02:31 PM

Hmm, I still get this error when running

carton exec -- ./admin/replication/LoadReplicationChanges

Commit fe311bcae95be66398 didn't touch the line, which causes the error at all:

sub COVER_ART_ARCHIVE_UPLOAD_PREFIXER { sprintf("http://%s.s3.us.archive.org/", shift) };

[ Permalink | « Hide ]

Oliver Charles added a comment - 21/May/12 10:16 AM

Try f16d9e5.

Oliver Charles made changes - 21/May/12 10:16 AM

Status	Reopened [ 4 ]	Closed [ 6 ]
Fix Version/s		Bug fixes, 2012-05-28 [ 10133 ]
Fix Version/s	Schema change, 2012-05-15 [ 10117 ]
Resolution		Fixed [ 1 ]

[ Permalink | « Hide ]

Johannes Weißl added a comment - 22/May/12 11:09 PM - edited

I can't find commit f16d9e5... ~~although I can't seem to reproduce the error either~~.

I know now where the error comes from:

eval `./admin/ShowDBDefs`

https://github.com/metabrainz/musicbrainz-server/blob/2b7592b40c5e600c91c7353ec2f5f148a79df603/admin/cron/slave.sh#L4

Johannes Weißl made changes - 22/May/12 11:17 PM

Resolution	Fixed [ 1 ]
Status	Closed [ 6 ]	Reopened [ 4 ]

[ Permalink | « Hide ]

Oliver Charles added a comment - 23/May/12 07:52 AM

I know, that's what that commit fixed. Paste git rev-parse HEAD, your DBDefs.pm and the exact warning you're currently getting.

[ Permalink | « Hide ]

Oliver Charles added a comment - 23/May/12 09:10 AM

Ok, it seems I didn't actually push. Grab master, that commit is now there.

Oliver Charles made changes - 23/May/12 09:10 AM

Status	Reopened [ 4 ]	Closed [ 6 ]
Resolution		Fixed [ 1 ]

[ Permalink | « Hide ]

Johannes Weißl added a comment - 23/May/12 09:41 AM

Thanks a lot, the error is now fixed!