Issue Details (XML | Word | Printable)

Key: MBS-4659
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Joachim LeBlanc
Reporter: Antti Jokipii
Votes: 1
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Auto-editor approval should be shown in edit list view.

Created: 05/May/12 01:38 PM   Updated: 03/Sep/12 10:34 AM   Resolved: 03/Sep/12 10:34 AM
Component/s: None
Affects Version/s: None
Fix Version/s: Bug fixes, 2012-09-03

Issue Links:
Duplicate
 


 Description  « Hide

If it is intentional that auto-editor approve doesn't count as yes vote? example http://musicbrainz.org/edit/17505235 has 0 yes and 0 no votes.
Then approval should be also shown in edits list view. Now I have hard times to tell which ones are accepted by expiration and which ones by auto-editor approval without opening each edit.



Sort Order: Ascending order - Click to sort in descending order
nikki added a comment - 05/May/12 02:26 PM

It also seems that approving an edit doesn't increase the editor's yes votes on their profile page either.


nikki added a comment - 06/May/12 12:31 AM

assigning as per request on http://chatlogs.musicbrainz.org/musicbrainz/2012/2012-05/2012-05-05.html#T19-18-28-227686

and my suggestion for how to show the info:

19:23:51 [nikki] if they're not going to be counted as yes votes (even though they are basically just a super-yes : P), the profile page needs another row for approves...
19:24:18 [nikki] and maybe we could replace "closed:" with "approved:" if the edit was approved in the edit search results
19:24:59 [nikki] ('cause I can't think of any other concise but understandable way of showing it as a separate vote)


Joachim LeBlanc added a comment - 12/May/12 06:43 AM

Joachim LeBlanc added a comment - 12/May/12 06:47 AM

I guess I should also mention a few things:

Yes, it is intentional that approvals do not count as yes votes. They are more than just a yes vote, auto-editor approvals have no effect on the voting process so they shouldn't be considered as a yes vote.

In my fix up for review, I added the Approve vote statistic on the editor profile as nikki suggested and also changed the "Closed:" line to "Approved:" so that way on edit lists they are discernable from normal closing procedures.


nikki added a comment - 04/Jul/12 07:27 AM

What happened to this?


Oliver Charles added a comment - 09/Jul/12 10:49 AM

I do not see an open review for this so I am reopening it and removing the fix version.