[#MBS-4640] Clicking cover art opens box with "��" (4 U+FFFD) - MusicBrainz JIRA

MusicBrainz Server

Clicking cover art opens box with "��" (4 U+FFFD)

Created: 01/May/12 07:40 PM Updated: 11/May/12 08:50 AM Resolved: 04/May/12 10:07 AM

Component/s:

Cover art

Affects Version/s:

None

Fix Version/s:

Schema change, 2012-05-15

Environment:

Opera/9.80 (X11; Linux x86_64; U; Edition Next; en) Presto/2.10.289 Version/12.00

Issue Links:

Duplicate

This issue is duplicated by:

~~MBS-4692~~ Cover art pop-up not working correctly

~~MBS-4694~~ Sidebar tries to use cover art archive popup for non-CAA covers

Description

« Hide

1. http://musicbrainz.org/release/443dd3af-eedd-4e1b-a7ec-6ca44274e265
2. Click cover art
3. A box with "close or Esc Key" and "��" appears

Clicking cover art at http://musicbrainz.org/release/443dd3af-eedd-4e1b-a7ec-6ca44274e265/cover-art works just fine, it's only from the main release page that the problem occurs.

Sort Order:

[ Permalink | « Hide ]

Oliver Charles added a comment - 04/May/12 09:40 AM

As this is an easy bug to stumble across, I'm scheduling it for the next release.

[ Permalink | « Hide ]

Oliver Charles added a comment - 04/May/12 10:07 AM

Fixed in 430fe9b.

Commit message is:

MBS-4640: Remove ThickBox logic for displaying web pages, we only need it for images
    
    MBS-4640 is a bug where viewing the /front image fails. This happens because
    ThickBox thinks that as this URL doesn't have .jpg, that we are probably
    intending to display a HTML fragment. We don't need this functionality (and it's
    wrong), so I've just remove all of that logic entirely. It now always trys to
    display images.

[ Permalink | « Hide ]

patate12 added a comment - 11/May/12 08:49 AM

And the same blank rectangle appears for ASIN-pic releases like Honesty (from MBS-4693).

Clicking cover art opens box with "����" (4 U+FFFD)

Clicking cover art opens box with "��" (4 U+FFFD)