Issue Details (XML | Word | Printable)

Key: MBS-4622
Type: Bug Bug
Status: Open Open
Priority: Minor Minor
Assignee: Unassigned
Reporter: nikki
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Improve handling of cover art when JS is off

Created: 29/Apr/12 03:38 PM   Updated: 22/Mar/13 10:09 AM
Component/s: Cover art
Affects Version/s: None
Fix Version/s: None


 Description  « Hide

Right now we set a cookie and then check the cookie to see whether a user has JS enabled. This breaks when the user turns off JS after the cookie has been set (you have to clear the cookies for it to realise that JS is no longer on) and means that after doing that, all cover art images fail to load until you turn JS back on or clear your cookies.

It feels like we're reinventing the wheel when HTML already has a <noscript> tag for this sort of thing. Unless I'm completely missing something, we could do something like <script>do complicated shit to determine which image to use</script><noscript>insert 250 thumbnail and hope it's been generated</noscript>

I realise this isn't a high priority thing to fix, but I'm reporting it anyway because the way we're doing JS detection is buggy. : P



Sort Order: Ascending order - Click to sort in descending order
Kuno Woudt added a comment - 18/May/12 10:09 AM

I personally don't think we should spend any more time on non-js support. We already require javascript in many places, So, I vote WONTFIX on this particular issue and getting rid of the javascript detection entirely.