Issue Details (XML | Word | Printable)

Key: MBS-4589
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Ian McEwen
Reporter: nikki
Votes: 1
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Add missing entities does not remember "Add new artist" selections

Created: 22/Apr/12 03:00 AM   Updated: 23/Jul/12 05:24 AM   Resolved: 23/Jul/12 05:24 AM
Component/s: None
Affects Version/s: None
Fix Version/s: Bug fixes, 2012-07-23

Issue Links:
Relates
 


 Description  « Hide

This is similar to MBS-4193 but in this case it only forgets "Add new artist" selections. If you select an actual artist, that is remembered, so I don't know if they're caused by the same problem.

Go to http://test.musicbrainz.org/release/add (or http://musicbrainz.org/release/add if test is still broken)
Enter a release name and artist (don't select an existing artist)
Go to the tracklist tab and enter a track name
Go the the add missing entities tab
Select "Add new artist" and click "Next"

Result: You're brought back to the add missing entities tab (because you haven't entered a sortname) but "Add new artist" is no longer selected. If you add a sortname and try to continue, it will bring you back again because this time you didn't select "Add new artist" (again).



nikki made changes - 22/Apr/12 03:01 AM
Field Original Value New Value
Link This issue has related issue MBS-4193 [ MBS-4193 ]
Ian McEwen added a comment - 09/Jul/12 02:50 AM

root/release/edit/missing_entities.tt lines 60/61 seem relevant here, it looks like checked="checked" isn't getting set in the case of "Add new artist", though it is for suggested artists by lines 52-54. If I'm reading the code right, it should reuse the same form when it's redirected to itself, so this should do it.


Ian McEwen added a comment - 09/Jul/12 03:01 AM

I'm guessing that 4193 is a different problem where the form when you end up back on the page isn't getting instantiated properly, and thus just plain doesn't have the data to set the selection for you.


Ian McEwen made changes - 09/Jul/12 06:48 PM
Assignee Ian McEwen [ ianmcorvidae ]
Ian McEwen made changes - 09/Jul/12 06:50 PM
Status Open [ 1 ] Review Submitted [ 5 ]
Oliver Charles made changes - 13/Jul/12 12:32 PM
Status Review Submitted [ 5 ] In Beta Testing [ 10002 ]
Oliver Charles added a comment - 13/Jul/12 12:33 PM

ianmcorvidae/mbs-4589-missing-entities is now in beta testing.


Oliver Charles made changes - 13/Jul/12 12:33 PM
Fix Version/s Bug fixes, 2012-07-24 [ 10148 ]
Oliver Charles made changes - 23/Jul/12 05:24 AM
Status In Beta Testing [ 10002 ] Closed [ 6 ]
Resolution Fixed [ 1 ]