[#MBS-4568] Add <bdi> tags to help with rendering of RTL text - MusicBrainz JIRA

MusicBrainz Server

Add <bdi> tags to help with rendering of RTL text

Created: 18/Apr/12 05:03 AM Updated: 10/Dec/12 05:53 PM Resolved: 10/Dec/12 12:29 PM

Component/s:

Data display, Internationalization

Affects Version/s:

None

Fix Version/s:

2012-12-10

Issue Links:

Depends

This issue depends on:

~~MBS-5246~~ Implement html5 validation using validator.nu.

Relates

This issue is related to:

MBS-1559 Right-to-left parentheses are broken

Description

« Hide

Splitting from MBS-1559 since there are two separate RTL issues here.

See http://www.w3schools.com/html5/tag_bdi.asp
This tag is designed to avoid rendering disasters like http://musicbrainz.org/recording/a5013bc1-0d72-45e9-ac59-5dd57a1abfae where the RTL-ness of the artist name leaks into the following text.

Sort Order:

[ Permalink | « Hide ]

nikki added a comment - 18/Apr/12 05:35 AM

http://codereview.musicbrainz.org/r/1860/

[ Permalink | « Hide ]

Nicolás Tamargo added a comment - 01/Jun/12 08:16 PM

There are no bdi tags anywhere I can find - this seems not to have been merged correctly.

[ Permalink | « Hide ]

Oliver Charles added a comment - 17/Jul/12 11:35 AM

Moving tickets out of 2012-07-24 as this release is now frozen for new merges.

[ Permalink | « Hide ]

Oliver Charles added a comment - 31/Jul/12 04:50 PM

Moving to 2012-08-20 release as we are now in freeze for 2012-08-06.

[ Permalink | « Hide ]

Ian McEwen added a comment - 09/Aug/12 07:04 AM

This was reverted in commit 69755eca (https://github.com/metabrainz/musicbrainz-server/commit/69755ecaf5d28f78313b0c8f38107e43608f7e25) with no explanation I can see - Oliver, what's up here?

[ Permalink | « Hide ]

Oliver Charles added a comment - 09/Aug/12 10:39 AM

Oh, sorry about documenting that revert badly

The problem is <bdi> is HTML5, but our tests can only handle HTML4 it seems, and thus fail when <bdi> tags are added. There is more discussion at http://chatlogs.musicbrainz.org/musicbrainz-devel/2012/2012-05/2012-05-16.html#T13-17-12-462764

[ Permalink | « Hide ]

Kuno Woudt added a comment - 09/Aug/12 02:38 PM - edited

note, I grabbed the ticket (as in assigned it to myself) to spend some time on moving us over to validating using validator.nu - I've done some testing in that area, but then got side-tracked with other stuff. So currently this is a bit stalled, eventually I'll continue on it. Though if someone else is interested, feel free to steal the ticket

[ Permalink | « Hide ]

Ian McEwen added a comment - 14/Aug/12 02:57 AM

Moving to next fix version, since we're in freeze.

[ Permalink | « Hide ]

Oliver Charles added a comment - 29/Aug/12 10:15 AM

Moving to the next release as we're in freeze now.

[ Permalink | « Hide ]

Oliver Charles added a comment - 24/Sep/12 03:36 PM

Merge window for 2012-10-01 is now shut; moving to next version.

[ Permalink | « Hide ]

Oliver Charles added a comment - 08/Oct/12 10:05 AM

The window for shipping this to beta testing has closed, so this will have to wait for the next release.

[ Permalink | « Hide ]

patate12 added a comment - 10/Dec/12 05:53 PM

OMG, I discover this ticket because I just see <bdi> tags everywhere, including editor names.
(that breaks quite some userjs).
Oliver you were wondering if that was applied, then yes it's in production.