Issue Details (XML | Word | Printable)

Key: MBS-4366
Type: Improvement Improvement
Status: Reopened Reopened
Priority: Normal Normal
Assignee: Alastair Porter
Reporter: Aurélien Mino
Votes: 3
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Display front cover art on user collection page

Created: 27/Feb/12 04:59 PM   Updated: 11/Sep/12 08:31 PM
Component/s: Collections, Data display
Affects Version/s: None
Fix Version/s: None


 Description  « Hide

It would be nice if a thumbnail front cover art could be displayed next to the release title on collection page (http://musicbrainz.org/collection/<GID>)



Sort Order: Ascending order - Click to sort in descending order
Alastair Porter added a comment - 12/Jul/12 01:49 PM

I've made some mockups of ways to show this information:

http://musicbrainz.music.mcgill.ca/~alastair/collection1.html
http://musicbrainz.music.mcgill.ca/~alastair/collection2.html

I'm looking for votes on what layout looks better. I'm thinking that both might be useful, for instance, showing the full images by default, but being able to switch to the list for other operations such as delete, move (MBS-1806).


nikki added a comment - 12/Jul/12 02:18 PM

First one for me. I wouldn't want to use the second one at all.


Aurélien Mino added a comment - 12/Jul/12 02:24 PM

First one for me too.


patate12 added a comment - 12/Jul/12 03:10 PM

I like 1st one (but with smaller icons would be better for me) and 2nd one very nice seeing big covers.
Maybe like you say we would have a switcher : « text | icons | covers »
where text is our current list,
icons is your 1st one with smaller pics (32×32px for instance) and
covers is your 2nd one.


Alastair Porter added a comment - 12/Jul/12 07:44 PM

Wow, OK. The votes have spoken. I much prefer 2, but will look at getting 1 going first, instead. I'll look at adding 2 as an extra option in the future. I think the options should just be icons | covers. There's no reason to keep text around.


Ian McEwen added a comment - 12/Jul/12 08:19 PM

+1 for "do #1 now, add a switcher later to have both"


Alastair Porter added a comment - 03/Aug/12 02:04 AM

I'd like some feedback on how to approach this issue. The sidebar currently uses javascript to load the image (root/components/common-macros.tt display_artwork), and tries the 250 thumb, full size, and finally any given fallback (e.g. from asin).

Is it important to have the same level of fallback on a list here, or can we just assume the 250 thumb will be available (maybe with a single layer of fallback to add a "image not here" image)? (Specifically looking for feedback from Warp, who did the sidebar)


Kuno Woudt added a comment - 03/Aug/12 05:55 AM

Any cover art display code should re-use our existing cover art display code. Do not re-invent the wheel with different fallbacks and such – if the existing macro isn't good enough for your use-case, improve the macro instead, so we get the benefits elsewhere as well.

So use the "display_artwork" macro from root/components/common-macros.tt


Ian McEwen added a comment - 03/Aug/12 05:59 AM

Potentially conflicting changes alert: I have a branch in beta at present that makes us use the 500px images (MBS-4674). Shouldn't actually matter, but it might make master conflict by next Monday if you need to do any improvements to that code.


Oliver Charles added a comment - 11/Sep/12 08:31 PM

This failed code review – http://codereview.musicbrainz.org/r/2149/