[#MBS-4354] Edits through the webservice should display application name + version - MusicBrainz JIRA

MusicBrainz Server

Edits through the webservice should display application name + version

Created: 23/Feb/12 05:20 PM Updated: 03/Sep/12 10:34 AM Resolved: 03/Sep/12 10:34 AM

Component/s:

Edit system

Affects Version/s:

Bug fixes, 2012-02-06

Fix Version/s:

Bug fixes, 2012-09-03

Description

« Hide

If there is a problem with any edit submitted through the webservice (e.g. http://musicbrainz.org/edit/16640470) it may be the result of a bug in the client application, not necessarily an error of the associated musicbrainz user.

As such, it would be very useful for other editors to know which application + version was used to create the edit.

Sort Order:

[ Permalink | « Hide ]

Oliver Charles added a comment - 27/Feb/12 12:32 PM

The 'edit barcodes' edit type does not currently mandate the client query parameter. Should we change the API?

[ Permalink | « Hide ]

Kuno Woudt added a comment - 27/Feb/12 03:00 PM

I think the client query parameter was mostly for the benefit of the load balancers, so they can easily block/dispatch on the URL alone.

We really should be using the User Agent header for this stuff IMO. now that we've got most webservice consumers setting their user agent properly perhaps we can deprecate ?client= and use the User Agent properly.

[ Permalink | « Hide ]

Oliver Charles added a comment - 06/Aug/12 08:01 PM

We will support both ?client, and fall back to user agent.

[ Permalink | « Hide ]

Oliver Charles added a comment - 07/Aug/12 01:06 PM

In review with http://codereview.musicbrainz.org/r/2125/

[ Permalink | « Hide ]

Ian McEwen added a comment - 14/Aug/12 02:56 AM

Moving to next fix version, since we're in freeze.