Issue Details (XML | Word | Printable)

Key: MBS-4340
Type: Sub-task Sub-task
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Ian McEwen
Reporter: Aurélien Mino
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server
MBS-4107

edit details template is wrongly retrieved from translated edit name

Created: 19/Feb/12 01:56 PM   Updated: 09/Jul/12 07:33 AM   Resolved: 09/Jul/12 07:33 AM
Component/s: Internationalization
Affects Version/s: None
Fix Version/s: Bug fixes, 2012-07-09

Issue Links:
Relates
 


Sort Order: Ascending order - Click to sort in descending order
Aurélien Mino added a comment - 19/Feb/12 02:00 PM

The edit_template property is determined from edit_name that is translated when language is not English:
https://github.com/metabrainz/musicbrainz-server/blob/master/lib/MusicBrainz/Server/Edit.pm#L15

As a consequence, edit details can't be displayed if language is not English:
http://i18n.mbsandbox.org/edit/14678011 shows error

Couldn't render template "file error - edit/details/ajouter_un_média.tt: not found"

("Add medium" translates to "Ajouter un média" in French)


Ian McEwen added a comment - 19/Feb/12 11:23 PM

Edit types being in the database (rather than defined in sub edit_name in every edit type) would probably make for a cleaner solution to this


Ian McEwen added a comment - 08/Jun/12 04:30 AM

In light of my http://codereview.musicbrainz.org/r/1941/ changes, I'll probably add an l_edit_name function to edits, so it's possible to specify translated or untranslated, then migrate things where appropriate.


Ian McEwen added a comment - 28/Jun/12 08:07 AM