[#MBS-4313] "has cover art" missing from Relationship Type multiple select box on "Search for Edits" page. - MusicBrainz JIRA

MusicBrainz Server

"has cover art" missing from Relationship Type multiple select box on "Search for Edits" page.

Created: 15/Feb/12 03:51 AM Updated: 23/Jul/12 05:24 AM Resolved: 23/Jul/12 05:24 AM

Component/s:

None

Affects Version/s:

None

Fix Version/s:

Bug fixes, 2012-07-23

Description

« Hide

As per title; might just be a simple human-error omission.

Workaround: Set "&conditions.X.args=78".

Sort Order:

Oliver Charles made changes - 15/Feb/12 02:18 PM

Field	Original Value	New Value
Project	MusicBrainz Search Server [ 10020 ]	MusicBrainz Server [ 10000 ]
Key	SEARCH-181	~~MBS-4313~~

Oliver Charles made changes - 15/Feb/12 02:20 PM

Assignee

Paul Taylor [ ijabz ]

[ Permalink | « Hide ]

nikki added a comment - 20/Apr/12 03:16 PM

Here's all the ones which appear to be missing:

artist-recording:
297 arranger

artist-release_group:
65 tribute
62 artists and repertoire
63 creative direction
61 travel

artist-url:
185 online community
197 lyrics

artist-work:
293 arranger
162 misc

label-recording:
206 publishing

label-release:
66 publishing

label-work:
208 publishing:

recording-release:
69 samples material

recording-url:
302 license
285 allmusic

release-release:
1 part of set
3 supporting release

release-url:
78 cover art link
301 license
288 discography entry

release_group-release_group:
11 single from

release_group-url:
93 lyrics

url-work:
271 lyrics
274 score
273 other databases
270 misc

work-work:
281 parts
241 other version
239 medley

[ Permalink | « Hide ]

Ian McEwen added a comment - 03/Jul/12 07:53 PM

The code accidentally trimmed the entire top level: in root/edit/search_macros.tt, predicate_link_type calls relationship_node on each type group's children, but relationship_node doesn't use the immediate thing it's passed, only it's children – so, for the top level, they get skipped. Patch incoming.

Ian McEwen made changes - 03/Jul/12 07:54 PM

Assignee

Ian McEwen [ ianmcorvidae ]

Ian McEwen made changes - 03/Jul/12 07:57 PM

Status

Open [ 1 ]

Review Submitted [ 5 ]

Oliver Charles made changes - 09/Jul/12 10:48 AM

Fix Version/s

Bug fixes, 2012-07-24 [ 10148 ]

[ Permalink | « Hide ]

Oliver Charles added a comment - 09/Jul/12 12:51 PM

ianmcorvidae/mbs-4313-edit-search-missing-relationships merged into beta.

Oliver Charles made changes - 09/Jul/12 12:51 PM

Status

Review Submitted [ 5 ]

In Beta Testing [ 10002 ]

Oliver Charles made changes - 23/Jul/12 05:24 AM

Status	In Beta Testing [ 10002 ]	Closed [ 6 ]
Resolution		Fixed [ 1 ]