Issue Details (XML | Word | Printable)

Key: MBS-4143
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Oliver Charles
Reporter: Brian Schweitzer
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Removing a tag from a well-tagged entity can give "undefined" as text

Created: 07/Jan/12 08:31 AM   Updated: 17/Sep/12 10:29 AM   Resolved: 17/Sep/12 10:29 AM
Component/s: JavaScript
Affects Version/s: Bug fixes, 2011-12-22
Fix Version/s: 2012-09-17

File Attachments: None
Image Attachments:

1. Screenshot from 2012-08-30.png
(127 kB)


 Description  « Hide

If you have an artist with multiple tags, enough that "more..." displays, and you have a tag there of your own which is displaying in the limited # in the sidebar, and you remove that tag, "undefined" displays, instead of "more...".

In this case, I was removing the one tag I had on http://musicbrainz.org/artist/338f9d5d-9327-4f01-bb99-0cdf22c48565



Oliver Charles added a comment - 14/Aug/12 03:37 PM

I went to that page, added a 'american' tag (which displays in the top tags) and then refreshed the page and removed it. I did not see undefined anywhere. If you can still reproduce this bug, please reopen this ticket.


Oliver Charles made changes - 14/Aug/12 03:37 PM
Field Original Value New Value
Status Open [ 1 ] Closed [ 6 ]
Resolution Cannot Reproduce [ 5 ]
Oliver Charles made changes - 14/Aug/12 03:37 PM
Assignee Oliver Charles [ acid2 ]
Brian Schweitzer added a comment - 30/Aug/12 12:21 PM

I just reproduced this, rather simply. Using Chrome on Ubuntu, I simply opened Victor Young's page. I had no tag set for him, so I added a 'american' tag, just as you did. "more" immediately turned into an unlinked "undefined". (See screenshot).

I then removed my 'american' tag, and refreshed.

I then was able to trigger "undefined" again four more ways.

I tagged him with 'production music', which is one of the largest tags. I got a brief flash of 'undefined', then that text changed to 'production music' - it looks like the element is being given text after it is inserted, rather than beforehand. This second one's not too bad, because it's quickly fixed by the script, but the flash of undefined doesn't look good.

I then refreshed, and was again able to trigger 'undefined' in the specific way described by the ticket text above - I simply removed my 'production music' tag, and clicked 'tag'. 'More' immediately became 'undefined', and stayed that way.

Then I tried one more thing. With it showing 'undefined', and the tag box empty, I clicked 'tag' again repeatedly. Each time it would alternate what text I got - 'more' or 'undefined', switching between them.

Figuring that maybe this was a temporary situation caused by having removed the tag within the same page instance, I refreshed again. The tag box was empty. The text showed "more". I again clicked on "tag" with nothing in the tag box. I again get "undefined", and just like before, "tag" now simply alternates between "more" and "undefined".

So this one's definitely still in there, likely in multiple ways.


Brian Schweitzer made changes - 30/Aug/12 12:22 PM
Attachment Screenshot from 2012-08-30.png [ 10517 ]
Brian Schweitzer made changes - 30/Aug/12 12:23 PM
Resolution Cannot Reproduce [ 5 ]
Status Closed [ 6 ] Reopened [ 4 ]
Oliver Charles added a comment - 31/Aug/12 12:08 PM

Thanks for the notes, seems that this bug does indeed still exist so this can stay open.


Oliver Charles made changes - 04/Sep/12 10:07 AM
Status Reopened [ 4 ] Review Submitted [ 5 ]
Oliver Charles added a comment - 04/Sep/12 10:07 AM

Oliver Charles made changes - 04/Sep/12 10:07 AM
Fix Version/s 2012-09-17 [ 10152 ]
Oliver Charles made changes - 07/Sep/12 11:18 AM
Status Review Submitted [ 5 ] In Beta Testing [ 10002 ]
Oliver Charles made changes - 17/Sep/12 10:29 AM
Status In Beta Testing [ 10002 ] Closed [ 6 ]
Resolution Fixed [ 1 ]