Issue Details (XML | Word | Printable)

Key: MBS-3851
Type: Improvement Improvement
Status: Closed Closed
Resolution: Duplicate
Priority: Normal Normal
Assignee: Unassigned
Reporter: Brian Schweitzer
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

text.js is not cached

Created: 28/Nov/11 10:02 PM   Updated: 25/Jan/13 06:09 AM   Resolved: 25/Jan/13 06:09 AM
Component/s: Admin, JavaScript, Scripts
Affects Version/s: Bug fixes, 2011-11-21
Fix Version/s: None

Issue Links:
Duplicate
 


 Description  « Hide

http://musicbrainz.org/text.js is set by headers to not be cached. All of the scripts that use it, however, are. I'm guessing it's because text_strings.tt is in musicbrainz-server/root/scripts rather than musicbrainz-server/root/static/scripts. It's a small file, but it adds an extra get request to every single page. It would seem that the server could be configured to set caching for that file equivalent in expiration/etc to the scripts that use it, which would slightly improve page load times for every page on the site by eliminating 99.99% of those get requests.



Sort Order: Ascending order - Click to sort in descending order
Oliver Charles added a comment - 01/Dec/11 04:19 PM

I don't think we can actually work on this until we decide how internationalization will work. Atm if you magically "change language", then text.js is serving something different. en.musicbrainz.org and de.musicbrainz.org is one solution, because en.musicbrainz.org/text.js is always the same thing then (in fact, it can be statically compiled).


Brian Schweitzer added a comment - 01/Dec/11 09:17 PM

Even were it an argument (musicbrainz.org?language=en, musicbrainz.org?language=de), I'd think the same would be true, it'd just be a little differently coded in the template (or perl backend that gets that arg).


Ian McEwen added a comment - 25/Jan/13 06:09 AM

Yes, this is older. But I closed the other one way back when, when this was fixed, so marking this one as duplicate.