|
Sort Order:
This has not actually been fixed. See attached; there still is no title visible. Navap, please clarify if this is a fix that hasn't yet been released yet (which lets us close this ticket), or if it still needs work. Editing a release displays the release's title in the <title>. Adding a release does not. I just tried to decipher the release editor code to try and figure out how to use the release's name when adding a new release and could't figure it out. I'll let someone else take that on. On a related note, I've got a local fix to Even if it's showing in the title on the edit page, if I can suggest, I would think it ought to be in the body as a header as well (as it used to be in the simple view). The above screenshot is perhaps an extremeish case, with 20 or so add forms open in tabs, but even if it were only 5 or so, the section of the title actually visible in a tab would be pretty well trimmed down to a point where the release title wouldn't be visible. The title is present in the html source, in add release mode, on the tracklist tab: ..
<div class="add-disc-tab tracklist" style="display: none">
<p>
Use the following fields to search for an existing tracklist.
</p>
<table class="import-search-fields">
<tr>
<td><label for="import-release">Release:</label></td>
<td><input type="text" id="import-release" class="release" value="Test Release Title" /></td>
<td rowspan="2"></td>
</tr>
..
it's just not actually visible on the rendered version of the page. I've not looked at the template, but perhaps the title can be accessed/inserted into the template using whatever same source is providing it to that bit of the template which already seems able to access it? Like I said earlier, I've added an h1 to every page of the release editor. I'll look again into displaying the release name when adding a new release. In review at http://codereview.musicbrainz.org/r/1861/ When editing a release the proper release header is displayed, when adding a new release "Add Release: Foo Bar" is displayed in the h1 and title. Moving tickets out of 2012-07-24 as this release is now frozen for new merges. Moving to 2012-08-20 release as we are now in freeze for 2012-08-06. Moving to next fix version, since we're in freeze. Moving to the next release as we're in freeze now. This really does negatively impact use of the RE, in that there's no way to know which one is which when you have 2+ REs open. It's now been pushed back 11 times, for what amounts to a template change. The release title is already present in the HTML, but hidden from display, as discussed up top here. No offense intended, but I have to ask. Can, perhaps, the priority of this be raised, so that it doesn't continue to just be pushed back again in the future? I've had this fixed for a while, but it's with all my other RE changes and I haven't had enough time to work on MB so it may take a little while longer to get pushed out. The previous review for this patch included other changes that were controversial – navap, could you perhaps isolate this change specifically, since this part should pass quite easily? If you feel you don't have the time, I'd be willing to adopt this and put it up for review (I'd probably just cherry-pick https://github.com/navap/musicbrainz-server/commit/8cb0314772503bde3168930b7efc36eb9a576500 I can do the isolation stuff this weekend. Is this what is causing that huge title + the whole list of tabs from the release view to appear on the RE on beta? I definitely want to have title + artist there, but can we make it not an h1? The RE needs space and that's just eating it. Also, please let's kill the tabs - having a link to the release page via the title should be more than enough. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||
Bug
Closed
Normal
Release Editor is not displaying the release title on the tracklist tab
Closing as fixed. The release title shows up on every page of the release editor.