Issue Details (XML | Word | Printable)

Key: MBS-3804
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Oliver Charles
Reporter: Johannes Weißl
Votes: 7
Watchers: 2
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Entering "Edit barcodes" edit should not be possible if nothing is being changed

Created: 23/Nov/11 12:26 AM   Updated: 04/Dec/11 10:21 AM   Resolved: 03/Dec/11 01:13 PM
Component/s: Edit system, Web service
Affects Version/s: None
Fix Version/s: Bug fixes, 2011-12-05

Issue Links:
Duplicate
 
Relates
 


 Description  « Hide

See e.g. http://musicbrainz.org/edit/15627133. It enters barcode "0077779183524", but this barcode is already there (entered in http://musicbrainz.org/edit/14409277). Such edits just spam the edit queue...



Sort Order: Ascending order - Click to sort in descending order
voiceinsideyou added a comment - 23/Nov/11 06:00 AM

Agreed; this is very irritating and not giving a good reputation to WS edit submission at all...


voiceinsideyou added a comment - 24/Nov/11 02:03 AM - edited

The suggestion in MBS-3812 that the WS actively remove the dupes (rather than flatly reject the edit) is probably the most practical here.

There is a wider issue here also that you can have 20 barcodes added in a single edit and if one is wrong you have no choice but to vote the whole thing down. This bulk approach is acceptable for auto-edits; but IMO not acceptable for non-trivial voteable edits.

It's also annoying to try and find which release/artist you're actually interested in within a large sea of barcodes/releases in the same edit. I think it should probably create 'n' distinct edits on the server side. Take http://musicbrainz.org/edit/15595608 for example - there is no way most voters are going to check every single release there.


Johannes Weißl added a comment - 24/Nov/11 08:36 AM

I raised the priority to "major", since edits like this are coming every hour .


Oliver Charles added a comment - 24/Nov/11 12:40 PM

I think this sounds urgent enough for the next release


patate12 added a comment - 24/Nov/11 01:52 PM

ANY edit should not be created for nothing. Not only barcode edits but ISRC submissions, PUID submissions, ALL TYPES of edits etc.


Oliver Charles added a comment - 24/Nov/11 02:31 PM

patate12: yes, we're aware of that, hence this bug report.

This is in code review for http://codereview.musicbrainz.org/r/1631/ and available for testing at http://test.musicbrainz.org


Johannes Weißl added a comment - 24/Nov/11 10:22 PM

Thanks Oliver for fixing this so soon! I tested it, and it seems to work! Just a really small thing: It still answers "<message><text>OK</text></message>" (e.g. it answers "<error><text>... is not a valid barcode</text>..." for invalid barcode).

If it is very easy to fix, a message like:
"<error><text>barcode ... is already present</text>"
would be helpful!


Oliver Charles added a comment - 24/Nov/11 10:35 PM

I don't consider trying to add a barcode that already exists an error.


Johannes Weißl added a comment - 24/Nov/11 10:47 PM

Ok, I thought you may just have forgotten to change the message. Other than that, it works very well for me! It even filters out redundant barcode submissions, instead of rejecting the whole edit !


Erik Warmelink added a comment - 04/Dec/11 10:21 AM

In my humble opinion, the edits should be welcomed. On the other hand, it is terribly overdone to have people vote for those confirmations; why these edits aren't auto-edits is completely beyond me.