Issue Details (XML | Word | Printable)

Key: MBS-3796
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Michael Wiencek
Reporter: Brian Schweitzer
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Release editor can allow the same artist to be created twice without either having a disambig comment

Created: 22/Nov/11 05:14 AM   Updated: 18/Feb/14 07:56 AM  Due: 03/Feb/14   Resolved: 18/Feb/14 07:56 AM
Component/s: Release editor
Affects Version/s: None
Fix Version/s: 2014-02-17


 Description  « Hide

The artist has to be a new name to the db; this does not work if there is at least 1 artist with the given name already in the db.

In two different tabs, have two instances of the RE going. In each, use an entirely new artist (one who would not conflict) for a track artist. In each, proceed to the "missing entities" tab. Add the sortname for the new artist, in each tab. Now proceed to finish out the add release edit in each tab.

You now have two artists with the same name, neither with a comment. Likely, there should be only one, or at worst, 2 but with at least one having a comment.

The data seems to be sanitized to check for such an instance only when the missing entity tab itself is loaded; there is no check when the overall edit is submitted, to see if any of the new entities have been created in that time between the missing entity tab being loaded and the overall edit being submitted.

I've not tested, but I would think this would have the same effect in inadvertently creating duplicate label entries via that same entity tab.



Sort Order: Ascending order - Click to sort in descending order
voiceinsideyou added a comment - 28/Nov/11 04:51 PM - edited

Do you actually have an example of this happening?

I believe it actually fails with an ISE triggered from constraints at the DB level; manifested in the RE with some error like "No artist was created for XXX"; for which there are probably tickets elsewhere.


Brian Schweitzer added a comment - 28/Nov/11 10:17 PM

I've merged real artists where this happened. But for example's sake, I've just now duplicated this; see releases:
http://musicbrainz.org/release/554bdeea-45f4-4201-84b9-7fdabbf4ad85
http://musicbrainz.org/release/e2b636db-b457-4b62-bec1-091f8e7bec6a

Note that both have the artist "Test Artist Do Not Delete MBS-3796" with sortname "This is a test artist" and no disambig comment. The two artists, in other words, are exactly identical. Yet they are separate artists:
http://musicbrainz.org/artist/e2422fcd-0dab-4a78-a915-f5c7ccce5dc3
http://musicbrainz.org/artist/56936d68-db2b-4841-b67a-e8de0f5d2d32

each created by a different add VA release edit:
http://musicbrainz.org/artist/e2422fcd-0dab-4a78-a915-f5c7ccce5dc3/edits
http://musicbrainz.org/artist/56936d68-db2b-4841-b67a-e8de0f5d2d32/edits

Note, the add edits are left open, so as to not have these go into the db forever. Thanks to reosarevok for voting no to make sure they can't pass. (But that also means this example is somewhat time-limited)


Oliver Charles added a comment - 10/Jul/12 07:03 AM

Due to be fixed within the next 12 months. Decided by the scheduling game and http://chatlogs.musicbrainz.org/musicbrainz-devel/2012/2012-07/2012-07-03.html#T19-01-57-842265