Issue Details (XML | Word | Printable)

Key: MBS-3794
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Oliver Charles
Reporter: patate12
Votes: 1
Watchers: 2
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

A "no votes" edits got wrong status "failed vote"

Created: 21/Nov/11 10:32 AM   Updated: 15/Apr/12 07:14 PM  Due: 26/Jun/12   Resolved: 10/Apr/12 10:40 AM
Component/s: Edit system
Affects Version/s: None
Fix Version/s: Bug fixes, 2012-04-10

Issue Links:
Relates
 


 Description  « Hide

I have a predefined search to check out which high quality data edits have failed due to lack of votes (no votes).
But I was recently surprised that (hopefully) I found such an edit with wrong status : edit:15485307 is "failed vote" but it should have been "no votes" so I could have found it and re-edit it.

If you're here reading, please vote the re-edit:15611427 so that it doesn't fail twice, thanks.



Sort Order: Ascending order - Click to sort in descending order
Oliver Charles added a comment - 22/Nov/11 08:46 AM

Not a major bug, it would have been major if it applied.


patate12 added a comment - 22/Nov/11 12:29 PM - edited

Maybe not major, it's important as we are loosing correction edits.
It's already a pain to go back and check if everything has passed for not having such a bug that even prevents you from checking that your edits have not vanished.


voiceinsideyou added a comment - 24/Nov/11 03:42 AM

The semantic difference between the text "Failed Vote" and "No votes" is a little weak to begin with. In either case the edit failed to get sufficient yes vs no votes in order to pass; it's just that the rules are different. But you're right that there's a valid use case for searching for these in particular; especially given how low our current voting rates are.


patate12 added a comment - 24/Nov/11 08:32 AM

Voice, it is not just a light glitch, it is a regression by the way. The failing edits due to high quality data with no votes had their own status, even in NGS (cf. my no votes search link in ticket desc.).


voiceinsideyou added a comment - 24/Nov/11 10:49 AM

I know they had their own status and I know its a regression. I've been around MB quite a while, remember? This is why I didn't change to "Improvement" and agreed that searching for these was a valid use case.

Regressions are regrettable and thus extra effort should be made to avoid them; but they're not fundamentally any more or less important than any other bug once they've happened. They need to be prioritised independently. Fixing newly created ISEs in Release Editor > fixing this regression; for example.



Oliver Charles added a comment - 27/Mar/12 02:41 PM

patate12 added a comment - 27/Mar/12 03:26 PM

Oliver, would it be possible to include a modbot edit note so that it wouldn't silently failĀ ?


Oliver Charles added a comment - 28/Mar/12 02:33 PM

Possibly, but that's for another ticket.