Issue Details (XML | Word | Printable)

Key: MBS-3791
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Ian McEwen
Reporter: Nicolás Tamargo
Votes: 6
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Drop Description from URLs

Created: 20/Nov/11 12:33 PM   Updated: 01/Dec/12 11:00 AM   Resolved: 02/Oct/12 02:32 PM
Component/s: Data display, Schema Change, User interface
Affects Version/s: None
Fix Version/s: Schema change, 2012-10-15

Issue Links:
Relates
 
Resolution
 


 Description  « Hide

Import of http://bugs.musicbrainz.org/ticket/3484

That ticket said "They're (probably) not used by anyone and the AR type says it all."

I'd add that when used, they're used for nonsense in 99% of the cases.

Removing this from the database is a schema change, but hiding them in the UI is not and could be done earlier if wanted.



ZaphodBeeblebrox added a comment - 20/Nov/11 05:41 PM

idk, for situations such as http://musicbrainz.org/edit/7093996 it can still be useful (iirc I had a few of this manner.)

info could be copied over to track annotations though.


Oliver Charles added a comment - 26/Mar/12 08:04 PM

All schema change tickets will be scheduled separately from normal scheduling cycles, so I am removing these from scheduling.ocharles.org.uk.

http://chatlogs.musicbrainz.org/musicbrainz-devel/2012/2012-03/2012-03-26.html#T19-36-54-3898


Oliver Charles made changes - 26/Mar/12 08:04 PM
Field Original Value New Value
Fix Version/s Unscheduled [ 10121 ]
Frederik "Freso" S. Olesen added a comment - 10/Jul/12 04:49 AM

I agree with Zaphod. There are definitely occurrences where having a description for an URL are useful.


Ian McEwen added a comment - 04/Sep/12 11:03 PM

We have a very small number of descriptions in the DB compared to the number of URLS (~28k versus over a million), and the vast majority of them are reiterations of ARs (official homepage for <artist>, wikipedia page for <artist>, 'homepage by a fan' (i.e. fan page), 'ASIN', unendingly many 'Discogs', etc.), irrelevant stuff ('.' for example, from when descriptions were required, and I'm also seeing a bunch of long numbers that don't mean anything), things that belong in annotations or other parts of releases/recordings/etc. ("11-track Japanese re-issue of Argo Cadet release, marketed by Universal Classics and Jazz", catalog numbers, barcodes, etc.), etc.

We have a lot of worthless noise in this field; I'd like to hear something that's useful to have a URL description for that can't just be put in a related entity's annotation to substantially better use; without that I think we should go forward with this (possibly even just in October, which also makes MBS-4747 a straightforward fix).


Ian McEwen added a comment - 04/Sep/12 11:05 PM

http://mbsandbox.org/~ianmcorvidae/url-descriptions.txt is a list of everything that's not null or the empty string (yes, the start there is all the ones that just have a single space).


Ian McEwen added a comment - 04/Sep/12 11:06 PM

oh, I forgot all of the ones that are just the URL being added. Because having it in both the url field and the description was apparently a good idea.


Ian McEwen made changes - 06/Sep/12 07:07 PM
Link This issue resolves MBS-4747 [ MBS-4747 ]
Oliver Charles made changes - 10/Sep/12 11:58 AM
Status Open [ 1 ] Decision Required [ 10000 ]
Oliver Charles added a comment - 10/Sep/12 11:58 AM

Moving to decision required as there is opposition for this ticket.


Ian McEwen made changes - 10/Sep/12 07:47 PM
Assignee Ian McEwen [ ianmcorvidae ]
Ian McEwen made changes - 10/Sep/12 07:54 PM
Fix Version/s Schema change, 2012-10-15 [ 10118 ]
Fix Version/s Unscheduled [ 10121 ]
Robert Kaye added a comment - 10/Sep/12 08:11 PM

we've agreed to go ahead with this and drop descriptions from URLs. When the descriptions are useful, the information should be conveyed in an annotation.


Robert Kaye made changes - 10/Sep/12 08:11 PM
Status Decision Required [ 10000 ] Open [ 1 ]
pankkake added a comment - 14/Sep/12 12:12 PM

Most of the descriptions I added on URLs have been useless - and at the time it was not publicly visible yet required, it was just random dirty words (nikki cleaned them up, though).

The only useful ones I added were about the language of the website, i.e. "en", "fr", etc.


Ian McEwen added a comment - 21/Sep/12 09:42 AM

http://codereview.musicbrainz.org/r/2315/ includes the schema change scripts; more work will of course follow.


Ian McEwen made changes - 21/Sep/12 09:42 AM
Status Open [ 1 ] In Progress [ 3 ]
Ian McEwen made changes - 27/Sep/12 10:51 PM
Status In Progress [ 3 ] Review Submitted [ 5 ]
Ian McEwen added a comment - 27/Sep/12 10:51 PM

The above-linked review should now be complete.


Oliver Charles added a comment - 02/Oct/12 02:32 PM

This has been merged to the schema change branch, but as it requires proper database testing it can't really go into beta testing... I'm closing this for now until we decide on testing strategies.


Oliver Charles made changes - 02/Oct/12 02:32 PM
Status Review Submitted [ 5 ] Closed [ 6 ]
Resolution Fixed [ 1 ]
Luca Salini made changes - 01/Dec/12 11:00 AM
Link This issue is related to STYLE-172 [ STYLE-172 ]