[#MBS-3757] 'releasegroup' used as the annotation type when displaying search results - MusicBrainz JIRA

MusicBrainz Server

'releasegroup' used as the annotation type when displaying search results

Created: 04/Nov/11 08:57 AM Updated: 17/Sep/12 10:29 AM Resolved: 17/Sep/12 10:29 AM

Component/s:

Web service

Affects Version/s:

None

Fix Version/s:

2012-09-17

Description

« Hide

From Nikki "I did notice that we display 'releasegroup' as the annotation type even though we have to use 'release-group' when querying. we might want to make that consistent"

Make sense, I don't think there is need to preserve backwards compatibility because searching by release-group doesnt work anyway on live

Sort Order:

[ Permalink | « Hide ]

Paul Taylor added a comment - 14/Nov/11 09:42 AM

Actually this incorrect, the Xml returned for searching annotations and for searching releasegroups always use 'release-group' rather than 'releasegroup' so it would be inconsistent to change it for annotations.

i.e
Annotation Search
<?xml version="1.0" encoding="UTF-8" standalone="yes"?><metadata xmlns="http://musicbrainz.org/ns/mmd-2.0#" xmlns:ext="http://musicbrainz.org/ns/ext#-2.0"><annotation-list offset="0" count="1"><annotation ext:score="100" type="release-group"><entity>aaa24cb5-404b-4f60-bba4-7b730325ae47</entity><name>3 Songs</name><text>Also known as Corduroy</text></annotation></annotation-list></metadata>

ReleaseGroup search
<metadata xmlns="http://musicbrainz.org/ns/mmd-2.0#" xmlns:ext="http://musicbrainz.org/ns/ext#-2.0"><release-group-list offset="0" count="1"><release-group ext:score="100" type="Single" id="52903501-1e29-3bb1-9819-b9281d8a8cf3"><title>Money $</title><artist-credit><name-credit><artist id="aec208a0-06a6-4610-a19d-8f7e3b251ef0"><name>Fischerman's Friend</name><sort-name>Fischerman's Friend</sort-name></artist></name-credit></artist-credit><release-list count="1"><release id="a8c6650b-f6fd-4b05-908f-7ea2d3671503"><title>Money $</title></release></release-list></release-group></release-group-list></metadata>

So when annotation displays releasegroup rather than release-group in the website that is because the website is translating the name, so we should either remove this translation on the website or just accept the website formats/changes things a little bit, for example when you select a search type from the dropdown list you select "Release Group" rather than "Releasegroup" or "release-group"

[ Permalink | « Hide ]

nikki added a comment - 14/Nov/11 11:12 AM

I think the website should either display "release-group" (since that's the type the search actually uses) or "release group" (since that's the way release group is normally written). "releasegroup" though is just odd, it doesn't match any other usage in MB as far as I know.