Issue Details (XML | Word | Printable)

Key: MBS-3678
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Ian McEwen
Reporter: brainz34
Votes: 3
Watchers: 3
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Blank annotations are shown in summary if they contained text prior

Created: 22/Oct/11 10:24 AM   Updated: 03/Sep/12 10:34 AM   Resolved: 03/Sep/12 10:34 AM
Component/s: Data display
Affects Version/s: None
Fix Version/s: Bug fixes, 2012-09-03

Issue Links:
Duplicate
 


 Description  « Hide

See <http://musicbrainz.org/release/0050667a-7ca1-4e65-82de-a22ba58cc269>

The annotation is blank, not even whitespace is there. But the release summary still shows

Annotation
Annotation last modified by brainz34 on 2011-10-22 10:15 UTC. View annotation history

I assume this is since the annotation contained text prior to this edit.

Sort Order: Ascending order - Click to sort in descending order
brainz34 made changes - 22/Oct/11 10:25 AM
Field Original Value New Value
Description See <http://musicbrainz.org/release/0050667a-7ca1-4e65-82de-a22ba58cc269>

The annotation is blank, not even whitespace is there. But the release summary still shows
{{{
Annotation
Annotation last modified by brainz34 on 2011-10-22 10:15 UTC. View annotation history
}}}
I assume this is since the annotation contained text prior to this edit. 		See <http://musicbrainz.org/release/0050667a-7ca1-4e65-82de-a22ba58cc269>

The annotation is blank, not even whitespace is there. But the release summary still shows
{quote}
Annotation
Annotation last modified by brainz34 on 2011-10-22 10:15 UTC. View annotation history
{quote}
I assume this is since the annotation contained text prior to this edit.
Component/s Data display [ 10006 ]
[ Permalink | « Hide ]
nikki added a comment - 22/Oct/11 02:23 PM

According to my replicated copy of the database, the annotation actually does contain whitespace (a single \r), so this is probably a duplicate of MBS-3416


[ Permalink | « Hide ]
brainz34 added a comment - 22/Oct/11 04:26 PM

The \r was removed by me in edit #15417115, after that I filed this issue.


[ Permalink | « Hide ]
nikki added a comment - 22/Oct/11 05:33 PM

There was still one in the database though, see http://pastebin.com/REcjHZ8j
I just edited the annotation myself and removed it though and now it no longer tries to show the annotation.


[ Permalink | « Hide ]
nikki added a comment - 14/Nov/11 11:26 PM

It seems that all empty annotations are now shown... whitespace or not :/


[ Permalink | « Hide ]
Nicolás Tamargo added a comment - 14/Nov/11 11:28 PM

This is now happening for all (previously existing) annotations, since the last "fix"


Oliver Charles made changes - 18/Nov/11 05:18 PM
Assignee Oliver Charles [ acid2 ]
[ Permalink | « Hide ]
Oliver Charles added a comment - 27/Feb/12 01:33 PM

Annotations are now shown, regardless of text content, if there is a history. This was introduced in MBS-1922, as a way to shown a link to the annotation history. I'm marking this decision required, as doing the obvious thing and hiding the annotation would break MBS-1922 again.


Oliver Charles made changes - 27/Feb/12 01:33 PM
Status Open [ 1 ] Decision Required [ 10000 ]
[ Permalink | « Hide ]
nikki added a comment - 27/Feb/12 01:40 PM

The add annotation and edit history links are in the sidebar, I don't see why the annotation history link can't also go in the sidebar.


[ Permalink | « Hide ]
Marko Sultsing added a comment - 27/Feb/12 05:04 PM

I think it makes sense to move "View annotation history" under the "Add/Edit annotation". I don't see much use to have it above the tracklist if there is no annotation itself.


nikki made changes - 03/Mar/12 03:31 PM
Link This issue is duplicated by MBS-4395 [ MBS-4395 ]
[ Permalink | « Hide ]
Oliver Charles added a comment - 26/Jun/12 07:49 PM

Reopening as we seem to have a clear consensus here.


Oliver Charles made changes - 26/Jun/12 07:49 PM
Status Decision Required [ 10000 ] Open [ 1 ]
Ian McEwen made changes - 20/Aug/12 10:16 PM
Assignee Ian McEwen [ ianmcorvidae ]
Ian McEwen made changes - 20/Aug/12 10:20 PM
Status Open [ 1 ] Review Submitted [ 5 ]
Oliver Charles made changes - 21/Aug/12 04:02 PM
Status Review Submitted [ 5 ] In Beta Testing [ 10002 ]
[ Permalink | « Hide ]
Luca Salini added a comment - 29/Aug/12 08:12 PM

No fix version is specified. Should we expect this to be included in the next release?


[ Permalink | « Hide ]
Ian McEwen added a comment - 29/Aug/12 08:21 PM

Luca: yeah; fix date must not have been set when this went into beta, but if something's in beta testing it should be the next release


Ian McEwen made changes - 29/Aug/12 08:21 PM
Fix Version/s Bug fixes, 2012-09-03 [ 10151 ]
Oliver Charles made changes - 03/Sep/12 10:34 AM
Status In Beta Testing [ 10002 ] Closed [ 6 ]
Resolution Fixed [ 1 ]
Atlassian JIRA (v4.0.1#471) | Report a problem | Request a feature | Contact administrators
Powered by a free Atlassian JIRA open source license for MetaBrainz Foundation. Try JIRA - bug tracking software for your team.