Issue Details (XML | Word | Printable)

Key: MBS-3610
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Oliver Charles
Reporter: patate12
Votes: 1
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Ratings : 502 Bad Gateway

Created: 07/Oct/11 09:02 AM   Updated: 16/Oct/12 07:55 PM  Due: 03/Jul/13   Resolved: 16/Oct/12 07:55 PM
Component/s: Data display
Affects Version/s: None
Fix Version/s: Schema change, 2012-10-15

File Attachments: None
Image Attachments:

1. beta-ratings-ok.png
(43 kB)

2. beta-ratings-removed.png
(49 kB)

3. myratings 502 (always).png
(19 kB)

4. myratings template-cancel (6.8.12).png
(49 kB)
Issue Links:
Resolution
 


 Description  « Hide

IT NEVER WORKED.
Logged as jesus2099, http://musicbrainz.org/user/jesus2099/ratings502 Bad Gateway after one minute loading

How to reproduce :

  1. Go to http://test.musicbrainz.org
  2. Load production jesus2099's ratings into test jesus2099 (otherwise empty)
  3. Log in as jesus2099 (password : mb)
  4. Go to http://test.musicbrainz.org/user/jesus2099/ratings502


patate12 made changes - 07/Oct/11 09:03 AM
Field Original Value New Value
Summary Ratings : 502 Vad Gateway Ratings : 502 Bad Gateway
patate12 made changes - 07/Oct/11 09:10 AM
Link This issue is resolved by MBS-2717 [ MBS-2717 ]
voiceinsideyou made changes - 07/Oct/11 09:15 AM
Component/s Data display [ 10006 ]
voiceinsideyou added a comment - 07/Oct/11 09:16 AM

It didn't 502 for me; so obviously a sporadic problem and thus not sure this adds a huge amount of value on top of the ticket that resolves it.


patate12 added a comment - 07/Oct/11 10:44 AM - edited

Well I think it does because I'm clicking it again now and, after more than one minute of no response, I get the 502 Bad Gateway error again.

Maybe you don't get it probably because you're either not logged in or not jesus2099.
Because maybe this 502 error is when it tries to load the version of the page in which you can revote your own votes ? (I say maybe because I never got to being able to use my ratings page ever, as far as I remember, since NGS was started).

Maybe this 502 error is a security fix for the HTTP server so that MBS-2623 does not happen.
But it would just be a fix to avoid overloading, not a functional fix that makes the feature work.

Maybe you could load the ratings in test, and log in as jesus2099 over there to see that 502 error. http://test.musicbrainz.org/user/jesus2099/ratings


voiceinsideyou added a comment - 07/Oct/11 01:18 PM

Maybe this 502 error is a security fix for the HTTP server so that MBS-2623 does not happen.

Uhh? Bad gateway is an internal timeout between delegating requests across servers; nothing more. It doesn't really have anything to do with client side rendering time which I believe MBS-2623 etc are about.

But it may be related to viewing your own ratings; dunno. Not sure there's much point comparing to test - that server runs on ice age time at the best of times for me :/


voiceinsideyou added a comment - 07/Oct/11 01:22 PM

Also, did you seriously edit your comment 3 times (causing the system to send me 3 emails) to add weird pretty stars?


patate12 added a comment - 07/Oct/11 02:38 PM

Anyway this problem has to be checked because people who don't care with ratings won't face it but people who care about ratings, tends to have many ratings and then all gets stuck.

MBS-2623 is about too much javascript that makes huge page crash or slow down clients. There's nothing else to do about it than optimize the voting bit for big releases. But for user rating pages, pagination would also ease the pain.

This MBS-3610 now is about server-side time-out on own rating page (when having reasonable amount of ratings).

So yes you're right that's two things.
The people stuck by those two different ratings problems (but both related to too much data) are the people willing to actively use ratings.

PS. I edited the comment to add a * remark to bottom new line about test server then saw that the jira suntax turned my second asterisk into an image (but not the ifrst astersik). I guess we protect characters with backslahs but as I was not sure I then wrote the same syntax at both place so that both get to stars instead ioprré"_é"h_p damxn I dont' know how to explain this in english whatveefr"ze


Oliver Charles made changes - 18/Nov/11 05:19 PM
Assignee Oliver Charles [ acid2 ]
Nicolás Tamargo added a comment - 28/Dec/11 01:49 PM

This takes a bit long to load for me but it eventually does (and I'm trying in a quite old computer). Is it still failing for you, patate12?


patate12 added a comment - 28/Dec/11 02:54 PM - edited

http://musicbrainz.org/user/jesus2099/ratings
On my first try (it's 2011-12-28 15:52 now)
Blank page, until after approximate 1 minute loading → 502 Bad Gateway ¬ nginx/0.7.65
Same for second, third (etc.) tries.
Smae in beta.
No ratings in test DB.

As I said I think maybe it works for people who are not logged in as jesus2099 (because MB won't load the change ratings code).


patate12 made changes - 28/Dec/11 02:54 PM
Comment [ http://musicbrainz.org/user/jesus2099/ratings
On my first try (it's 2011-12-28 15:52 now)
blank page, until 1:00 minut loading → 502 Bad Gateway
nginx/0.7.65 ]
patate12 added a comment - 06/Jan/12 09:20 AM

I've been trying my ratings page everyday to make sure : it is always 502 after 1 minute.

I think the only way to reproduce this bug is to take someone who has a fair amount of ratings (I suggest me), load all my ratings into a test user (ratings are not loaded in test) and click on My ratings (in My data top-right menu).


patate12 added a comment - 25/Feb/12 08:59 PM

I'l raising it because this my ratings feature never worked since the creation of this ticket (5 month ago approx.).

It means it crashes for a logged in user with as much ratings as me clicking his/her my ratings page.


patate12 made changes - 25/Feb/12 08:59 PM
Priority Normal [ 6 ] Major [ 3 ]
voiceinsideyou added a comment - 26/Feb/12 02:35 AM

jesus2099/patate12 - stop adjusting ticket priorities. These are not your decisions to make. This is the development team + bug triage team's decision. They will raise priority if the scope of the ticket is wide enough. If you want to make a case for attention to your ticket, have a discussion on the dev mailing list or with the team on IRC.

Besides, if this ticket were affecting a significant number of people, your ticket would attract votes. It has not, yet.


voiceinsideyou made changes - 26/Feb/12 02:35 AM
Priority Major [ 3 ] Normal [ 6 ]
patate12 added a comment - 26/Feb/12 09:58 AM

Yes sorry, I understand no one active here uses the ratings. :/
Unfortunately for me, using it.


patate12 made changes - 10/May/12 07:36 AM
Description http://musicbrainz.org/user/jesus2099/ratings *IT NEVER WORKED.*
*Logged as jesus2099*, http://musicbrainz.org/user/jesus2099/ratings → *502 Bad Gateway* after one minute loading

How to reproduce :

# Go to http://test.musicbrainz.org
# Load production jesus2099's ratings into test jesus2099 (otherwise empty)
# Log in as jesus2099 (password : mb)
# Go to http://test.musicbrainz.org/user/jesus2099/ratings → *502*
patate12 added a comment - 06/Jun/12 10:01 AM - edited

RARE EVENT !
Today I had a different error message : « 504 Gateway Time-out » (but it was just once, I'm back to the good old 502 now.


patate12 added a comment - 06/Jun/12 10:06 AM

Hey when I'm reading MBS-2623 I think I know why it's 502 now, maybe requests time-out have been set to 1 minute since back then, when it took at least 4 or 5 minutes to load !


Oliver Charles added a comment - 10/Jul/12 07:03 AM

Due to be fixed within the next 12 months. Decided by the scheduling game and http://chatlogs.musicbrainz.org/musicbrainz-devel/2012/2012-07/2012-07-03.html#T19-01-57-842265


Oliver Charles made changes - 10/Jul/12 07:03 AM
Due Date 2013-07-03 00:00:00.0
Fix Version/s Within 12 months [ 10114 ]
patate12 added a comment - 06/Aug/12 02:13 PM

Thanks so much Oliver and Réo !
For your information I have 502 99% of time, 504 0,5% and other various errors 0,5% of time.
My ratings 0% of time.
I will send some screen pictures...


patate12 made changes - 06/Aug/12 02:14 PM
Oliver Charles added a comment - 06/Aug/12 03:08 PM

We don't need pictures, we understand the problem just fine.


patate12 added a comment - 06/Aug/12 03:52 PM

Excellent.


patate12 made changes - 08/Aug/12 08:37 AM
Attachment myratings 502 (always).png [ 10498 ]
Oliver Charles added a comment - 24/Sep/12 03:06 PM

Oliver Charles made changes - 24/Sep/12 03:06 PM
Fix Version/s Schema change, 2012-10-15 [ 10118 ]
Fix Version/s Within 12 months [ 10114 ]
Oliver Charles made changes - 25/Sep/12 11:45 AM
Assignee Oliver Charles [ acid2 ]
Oliver Charles made changes - 25/Sep/12 11:45 AM
Status Open [ 1 ] Review Submitted [ 5 ]
Oliver Charles made changes - 01/Oct/12 02:57 PM
Status Review Submitted [ 5 ] In Beta Testing [ 10002 ]
patate12 added a comment - 01/Oct/12 03:46 PM

Sorry guys to spam this ticket but how is it working exactly.
Maybe the patch isn't fully delivered to beta yet...

When I go into my ratings page, I see a handful of [removed] links :

Although my ratings seem to be present in beta, as I see it for this artist, for instance :


patate12 made changes - 01/Oct/12 03:46 PM
Attachment beta-ratings-removed.png [ 10533 ]
Attachment beta-ratings-ok.png [ 10534 ]
Oliver Charles added a comment - 01/Oct/12 03:57 PM

Something seems broken there, I'll look into it. That's not the expected behaviour!


patate12 added a comment - 01/Oct/12 08:51 PM

WOW MY GOD OLIVER IT WORKS ! (I'm on another computer or you changed something)
YOU ARE MARVELLOUS !
I CAN SEE MY RATINGS !


Oliver Charles made changes - 16/Oct/12 07:55 PM
Status In Beta Testing [ 10002 ] Closed [ 6 ]
Resolution Fixed [ 1 ]