Issue Details (XML | Word | Printable)

Key: MBS-3590
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Oliver Charles
Reporter: voiceinsideyou
Votes: 2
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Release editor session timeout ISE super-ticket

Created: 04/Oct/11 01:57 PM   Updated: 29/Aug/12 04:58 PM   Resolved: 06/Aug/12 09:58 AM
Component/s: Release editor
Affects Version/s: None
Fix Version/s: Bug fixes, 2012-08-06

File Attachments: 1. Text File 2012-02-01 18.18 UTC crash.txt (59 kB) 01/Feb/12 07:00 PM - Kuno Woudt
2. Text File 2012-02-01 18.39 UTC crash.txt (12 kB) 01/Feb/12 07:00 PM - Kuno Woudt
3. File 2012-02-01-oddlogs.tar (770 kB) 01/Feb/12 07:02 PM - Kuno Woudt

Issue Links:
Duplicate
 
Relates


 Description  « Hide

This is an attempt to catalog all Internal Server Errors (ISE) variations you get on release editor (various tabs) after your session times out, to make it easy to find and link duplicates back here.

Release Information:

Caught exception in MusicBrainz::Server::Controller::ReleaseEditor::Add->add "Attribute (params) does not pass the type constraint because: Validation failed for 'HashRef' with value undef at /usr/local/share/perl/5.10.1/HTML/FormHandler.pm line 350

Release Duplicates:

Caught exception in MusicBrainz::Server::Controller::ReleaseEditor::Add->add "Can't use an undefined value as an ARRAY reference at /home/musicbrainz/musicbrainz-server/script/../lib/MusicBrainz/Server/Edit/Utils.pm line 146."

Tracklist / Recordings / Add Missing Entities / Edit Note

Caught exception in MusicBrainz::Server::Controller::ReleaseEditor::Add->add "Can't use an undefined value as a HASH reference at /home/musicbrainz/musicbrainz-server/script/../lib/MusicBrainz/Server/Wizard.pm line 257."



voiceinsideyou made changes - 04/Oct/11 01:59 PM
Field Original Value New Value
Link This issue is duplicated by MBS-3310 [ MBS-3310 ]
voiceinsideyou made changes - 04/Oct/11 02:00 PM
Link This issue is duplicated by MBS-3300 [ MBS-3300 ]
voiceinsideyou made changes - 04/Oct/11 02:02 PM
Link This issue is duplicated by MBS-3551 [ MBS-3551 ]
voiceinsideyou made changes - 04/Oct/11 02:04 PM
Priority Normal [ 6 ] Major [ 3 ]
voiceinsideyou made changes - 06/Oct/11 04:42 PM
Link This issue is related to MBS-3379 [ MBS-3379 ]
voiceinsideyou made changes - 06/Oct/11 04:52 PM
Link This issue is duplicated by MBS-3165 [ MBS-3165 ]
voiceinsideyou made changes - 08/Oct/11 02:48 AM
Link This issue is duplicated by MBS-3614 [ MBS-3614 ]
Kuno Woudt made changes - 11/Oct/11 10:46 AM
Status Open [ 1 ] Decision Required [ 10000 ]
Oliver Charles made changes - 14/Oct/11 04:44 PM
Fix Version/s Bug fixes, 2011-10-25 [ 10106 ]
Fix Version/s Bug fixes, 2011-10-10 [ 10103 ]
voiceinsideyou made changes - 19/Oct/11 07:21 AM
Link This issue is duplicated by MBS-3654 [ MBS-3654 ]
voiceinsideyou made changes - 21/Oct/11 03:00 AM
Link This issue is duplicated by MBS-3673 [ MBS-3673 ]
voiceinsideyou made changes - 23/Oct/11 03:57 AM
Link This issue is duplicated by MBS-3681 [ MBS-3681 ]
voiceinsideyou made changes - 24/Oct/11 03:34 AM
Link This issue is duplicated by MBS-3682 [ MBS-3682 ]
Brian Hagerty added a comment - 24/Oct/11 04:29 AM

I'm sure some timeout value is needed, but this is a problem. I lost about an hour's worth of work because of it.

One way to mitigate timeout problems would be to create a "Save Draft" function, much like the one Discogs has. This would be especially helpful for entering complicated releases (e.g., length, multi-disc, VA, classical-music releases).

A "save draft" function would be nice to have in any event.


voiceinsideyou made changes - 24/Oct/11 06:13 AM
Link This issue is duplicated by MBS-3687 [ MBS-3687 ]
voiceinsideyou made changes - 25/Oct/11 12:28 AM
Link This issue is duplicated by MBS-3690 [ MBS-3690 ]
voiceinsideyou made changes - 26/Oct/11 05:09 PM
Link This issue is duplicated by MBS-3676 [ MBS-3676 ]
Jim DeLaHunt added a comment - 26/Oct/11 05:14 PM

I second the suggestion for a "save draft" feature. I have lost over an hour's work entering a Release of an opera recording because I couldn't get the track list entered in time. There is a workaround – write up the track list in advance in another file, then start the Add Release wizard and quickly copy/past completed track titles from the other file – but it would be better if we could save drafts.


voiceinsideyou added a comment - 27/Oct/11 03:37 AM

While save draft would be useful; there are many complexities with getting that to work which will already break the release editor. e.g. cached row IDs or MBIDs which may be gone/merged/whatever by the time you press submit - there is currently no workflow to support that kind of thing.

I personally think that's a sledgehammer approach to this specific problem. The better approach IMO, is to see if it can be redesigned to make sure all required state for submission is client-side while you navigate the form; not relying on the server-side session state. I've no idea whether technically feasible though; presumably there was a reason that it's currently dependent on some server-side state.


Oliver Charles added a comment - 29/Oct/11 09:29 PM - edited

The plans for a new release editor are entirely client side (as far as state goes)


patate12 made changes - 07/Nov/11 08:55 AM
Description This is an attempt to catalog all ISE variations you get on release editor (various tabs) after your session times out, to make it easy to find and link duplicates back here.

Release Information:
{quote}
Caught exception in MusicBrainz::Server::Controller::ReleaseEditor::Add->add "Attribute (params) does not pass the type constraint because: Validation failed for 'HashRef' with value undef at /usr/local/share/perl/5.10.1/HTML/FormHandler.pm line 350
{quote}

Release Duplicates:
{quote}
Caught exception in MusicBrainz::Server::Controller::ReleaseEditor::Add->add "Can't use an undefined value as an ARRAY reference at /home/musicbrainz/musicbrainz-server/script/../lib/MusicBrainz/Server/Edit/Utils.pm line 146."
{quote}

Tracklist / Recordings / Add Missing Entities / Edit Note
{quote}
Caught exception in MusicBrainz::Server::Controller::ReleaseEditor::Add->add "Can't use an undefined value as a HASH reference at /home/musicbrainz/musicbrainz-server/script/../lib/MusicBrainz/Server/Wizard.pm line 257."
{quote}
This is an attempt to catalog all *Internal Server Errors* (*ISE*) variations you get on release editor (various tabs) after your session times out, to make it easy to find and link duplicates back here.

Release Information:
{quote}
Caught exception in MusicBrainz::Server::Controller::ReleaseEditor::Add->add "Attribute (params) does not pass the type constraint because: Validation failed for 'HashRef' with value undef at /usr/local/share/perl/5.10.1/HTML/FormHandler.pm line 350
{quote}

Release Duplicates:
{quote}
Caught exception in MusicBrainz::Server::Controller::ReleaseEditor::Add->add "Can't use an undefined value as an ARRAY reference at /home/musicbrainz/musicbrainz-server/script/../lib/MusicBrainz/Server/Edit/Utils.pm line 146."
{quote}

Tracklist / Recordings / Add Missing Entities / Edit Note
{quote}
Caught exception in MusicBrainz::Server::Controller::ReleaseEditor::Add->add "Can't use an undefined value as a HASH reference at /home/musicbrainz/musicbrainz-server/script/../lib/MusicBrainz/Server/Wizard.pm line 257."
{quote}
voiceinsideyou made changes - 09/Nov/11 05:32 PM
Link This issue has related issue MBS-3733 [ MBS-3733 ]
Oliver Charles made changes - 14/Nov/11 02:35 PM
Fix Version/s Bug fixes, 2011-11-14 [ 10110 ]
Fix Version/s Bug fixes, 2011-10-25 [ 10106 ]
Oliver Charles made changes - 15/Nov/11 06:53 PM
Fix Version/s Bug fixes, 2011-11-21 [ 10111 ]
Fix Version/s Bug fixes, 2011-11-14 [ 10110 ]
Oliver Charles made changes - 23/Nov/11 05:57 PM
Fix Version/s Bug fixes, 2011-12-05 [ 10119 ]
Fix Version/s Bug fixes, 2011-11-21 [ 10111 ]
Kuno Woudt added a comment - 28/Nov/11 06:26 PM

CallerNo6 reported a release editor crash on IRC today. Going through the logs around the time of this error I found this, which may be the cause of that particular crash:

2011-11-28 17:31:50.495995500 [error] Caught exception in engine "Couldn't save expires:c1c611ace1febf8bc148e4a72d67ccbce510332b / 1322508709 in memcached storage"
2011-11-28 17:31:50.513682500 [error] Caught exception in engine "Couldn't save expires:b3274601e3fc8de687794dc7c0f03322f4ebe3e7 / 1322508709 in memcached storage"
2011-11-28 17:31:50.761557500 [error] Caught exception in engine "Couldn't save session:30e3e872ea250e130e2620eea5ec83bdcd4f2f71 / HASH(0xdcdb630) in memcached storage"
2011-11-28 17:31:50.761593500 [error] Caught exception in engine "Couldn't save session:2924089e0507a6836e863c43839d73ce7375724e / HASH(0xdbfd580) in memcached storage"
2011-11-28 17:31:50.761756500 [error] Caught exception in engine "Couldn't save session:d33ba73b4192c0166a6145be27474e6014d4fe8f / HASH(0xd328970) in memcached storage"
2011-11-28 17:31:50.761758500 [error] Caught exception in engine "Couldn't save session:5bc87aa22d968e3ab8e078fe61d77b138a268f9e / HASH(0xcec90b8) in memcached storage"
2011-11-28 17:31:50.762572500 [error] Caught exception in engine "Couldn't save session:54eb36089347638cbff71f09659df211ab250de5 / HASH(0xcc89d70) in memcached storage"
2011-11-28 17:31:50.762819500 [error] Caught exception in engine "Couldn't save session:b3a55f5ab00d0ff7b8f7e0cc71a49a998f190677 / HASH(0xe6e7758) in memcached storage"
2011-11-28 17:31:52.037254500 [error] Caught exception in engine "Couldn't save session:d2315f15e9ce12e94b12b3918ad9164e568523c2 / HASH(0xe23cf00) in memcached storage"
2011-11-28 17:31:52.345097500 [error] Caught exception in engine "Couldn't save expires:30ca03bee2e1d51c1c4470b78691f309d9dceb4e / 1322508711 in memcached storage"
2011-11-28 17:31:52.463086500 [error] Caught exception in engine "Couldn't save expires:9f4fbccec06dae856597f011bff680dc551d906b / 1322508711 in memcached storage"


Kuno Woudt made changes - 05/Dec/11 03:23 PM
Link This issue is duplicated by MBS-3615 [ MBS-3615 ]
Oliver Charles made changes - 08/Dec/11 02:19 PM
Fix Version/s Bug fixes, 2011-12-22 [ 10122 ]
Fix Version/s Bug fixes, 2011-12-05 [ 10119 ]
nikki made changes - 31/Dec/11 04:13 PM
Link This issue is duplicated by MBS-4095 [ MBS-4095 ]
Oliver Charles made changes - 05/Jan/12 06:55 PM
Fix Version/s Schema change, 2012-01-12 [ 10116 ]
Fix Version/s Bug fixes, 2011-12-22 [ 10122 ]
nikki made changes - 08/Jan/12 05:45 AM
Link This issue is duplicated by MBS-3886 [ MBS-3886 ]
Oliver Charles made changes - 12/Jan/12 10:27 PM
Fix Version/s Bug fixes, 2012-01-23 [ 10126 ]
Fix Version/s Schema change, 2012-01-12 [ 10116 ]
Oliver Charles added a comment - 12/Jan/12 10:43 PM

As this issue has been delayed, I am moving it back to be rescheduled.


Oliver Charles made changes - 12/Jan/12 10:43 PM
Fix Version/s Bug fixes, 2012-01-23 [ 10126 ]
nikki made changes - 16/Jan/12 01:29 PM
Link This issue is duplicated by MBS-4188 [ MBS-4188 ]
Kuno Woudt made changes - 23/Jan/12 05:14 PM
Assignee Kuno Woudt [ warp ]
nikki made changes - 01/Feb/12 06:18 PM
Link This issue is duplicated by MBS-4265 [ MBS-4265 ]
Kuno Woudt added a comment - 01/Feb/12 06:45 PM

I'm seeing similar problems with the 502's and ISE's reported today. I'm attaching logs for two incidents.


Kuno Woudt made changes - 01/Feb/12 07:00 PM
Attachment 2012-02-01 18.18 UTC crash.txt [ 10377 ]
Attachment 2012-02-01 18.39 UTC crash.txt [ 10378 ]
Kuno Woudt made changes - 01/Feb/12 07:02 PM
Attachment 2012-02-01-oddlogs.tar [ 10379 ]
Kuno Woudt added a comment - 01/Feb/12 07:24 PM

Out of the 316 cache misses for wizard session keys in the oddlogs for the last 9 hours or so, only 24 are mentioned in the oddlogs for the past few days as being created. So, it appears we have a large number of wizard session keys just springing into existence without a trace.


Kuno Woudt added a comment - 01/Feb/12 10:03 PM

When the connection to memcached is lost for whatever reason, the release editor will crash. I'm not sure if any attempt is made to reconnect, but obviously that is being done correctly or at all.

irc log with a bit more detail: http://chatlogs.musicbrainz.org/musicbrainz-devel/2012/2012-02/2012-02-01.html#T20-43-41-404006


Kuno Woudt added a comment - 06/Feb/12 02:23 PM - edited

One crash has been fixed in commit 63db8e3685f077094581fea88c6553c5ec7159e8. beta has been updated with these changes.

If these problems still occur on beta.musicbrainz.org now or musicbrainz.org after the next release, please re-open this ticket.


Kuno Woudt made changes - 06/Feb/12 02:23 PM
Status Decision Required [ 10000 ] Closed [ 6 ]
Resolution Fixed [ 1 ]
Kuno Woudt added a comment - 06/Feb/12 07:07 PM

We had some trouble deploying this fix to musicbrainz.org.

I need to look into Catalyst::Plugin::Session::Store::Memcached::Fast to fix our use of memcached for sessions.


Kuno Woudt made changes - 06/Feb/12 07:07 PM
Resolution Fixed [ 1 ]
Status Closed [ 6 ] Reopened [ 4 ]
Assignee Kuno Woudt [ warp ]
voiceinsideyou added a comment - 07/Feb/12 02:33 PM

If you finally have once-and-for-all squashed it, it will be effort worth spent!


nikki made changes - 07/Feb/12 02:39 PM
Link This issue has related issue MBS-4281 [ MBS-4281 ]
nikki made changes - 28/Feb/12 02:11 PM
Link This issue is duplicated by MBS-4348 [ MBS-4348 ]
nikki made changes - 28/Feb/12 02:15 PM
Link This issue is duplicated by MBS-3976 [ MBS-3976 ]
nikki made changes - 20/Apr/12 11:58 PM
Link This issue is duplicated by MBS-4579 [ MBS-4579 ]
nikki made changes - 28/Apr/12 08:07 AM
Link This issue is duplicated by MBS-4615 [ MBS-4615 ]
nikki made changes - 28/May/12 03:12 AM
Link This issue is duplicated by MBS-4784 [ MBS-4784 ]
nikki made changes - 04/Jun/12 08:12 PM
Link This issue is duplicated by MBS-4800 [ MBS-4800 ]
nikki made changes - 11/Jul/12 08:48 PM
Link This issue is duplicated by MBS-5003 [ MBS-5003 ]
nikki made changes - 11/Jul/12 09:02 PM
Link This issue is duplicated by MBS-5003 [ MBS-5003 ]
Oliver Charles made changes - 11/Jul/12 09:10 PM
Link This issue is duplicated by MBS-5001 [ MBS-5001 ]
Oliver Charles made changes - 11/Jul/12 09:12 PM
Link This issue is duplicated by MBS-5003 [ MBS-5003 ]
Oliver Charles made changes - 11/Jul/12 09:23 PM
Link This issue is duplicated by MBS-5004 [ MBS-5004 ]
Oliver Charles made changes - 12/Jul/12 01:05 PM
Link This issue is duplicated by MBS-5006 [ MBS-5006 ]
Oliver Charles made changes - 13/Jul/12 12:27 PM
Link This issue is duplicated by MBS-5014 [ MBS-5014 ]
Oliver Charles made changes - 17/Jul/12 01:37 PM
Status Reopened [ 4 ] Review Submitted [ 5 ]
Oliver Charles added a comment - 17/Jul/12 01:37 PM

There's another patch at http://codereview.musicbrainz.org/r/2068/, but I'm not convinced it will solve the edge cases.


Oliver Charles made changes - 17/Jul/12 01:37 PM
Assignee Kuno Woudt [ warp ] Oliver Charles [ acid2 ]
nikki made changes - 17/Jul/12 09:30 PM
Link This issue is duplicated by MBS-5023 [ MBS-5023 ]
Oliver Charles made changes - 23/Jul/12 08:10 AM
Status Review Submitted [ 5 ] In Beta Testing [ 10002 ]
Oliver Charles made changes - 23/Jul/12 08:10 AM
Fix Version/s Bug fixes, 2012-08-06 [ 10149 ]
Oliver Charles made changes - 06/Aug/12 09:58 AM
Status In Beta Testing [ 10002 ] Closed [ 6 ]
Resolution Fixed [ 1 ]
Oliver Charles made changes - 29/Aug/12 04:58 PM
Link This issue is duplicated by MBS-4485 [ MBS-4485 ]