Issue Details (XML | Word | Printable)

Key: MBS-3476
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Oliver Charles
Reporter: Anonymous
Votes: 1
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Add more string substitutions for "join phrase"

Created: 20/Sep/11 02:46 PM   Updated: 03/Sep/12 10:34 AM  Due: 14/Nov/12   Resolved: 03/Sep/12 10:34 AM
Component/s: Edit system, JavaScript, Release editor
Affects Version/s: None
Fix Version/s: Bug fixes, 2012-09-03

Issue Links:
Relates
 


 Description  « Hide

When adding more than one artist to a track, one must enter " & " or ", " (with the spaces).

If one adds "," or "&" (no spaces) the Artist field does not render properly (i.e. without spaces).

I am suggesting adding logic so that if the join phrase is entered as "," (no spaces), it is substituted to ", " (with a space).
Also, if the text entered as "&" (no spaces) it is substituted to " & " (with spaces). These are common errors that lead to rejected edits that would be correct otherwise.



voiceinsideyou added a comment - 20/Sep/11 03:45 PM

Getting the correct number of spaces around join phrases is indeed quite annoying; and possibly could be corrected automagically for many cases. Perhaps this could be part of the "guess artist credits" component I suggest in MBS-3388.


voiceinsideyou made changes - 20/Sep/11 03:45 PM
Field Original Value New Value
Description When adding more than one artist to a track, one must enter " & " or ", " (with the spaces).

If one adds "," or "&" (no spaces) the Artist field does not render properly (i.e. without spaces).

I am suggesting adding logic so that if the join phrase is entered as "," (no spaces), it is substituted to ", " (with a space).
Also, if the text entered is "&" (no spaces) it is substituted to " & " (with spaces). These are common errors that lead to rejected edits that would be correct otherwise.

When adding more than one artist to a track, one must enter " & " or ", " (with the spaces).

If one adds "," or "&" (no spaces) the Artist field does not render properly (i.e. without spaces).

I am suggesting adding logic so that if the join phrase is entered as "," (no spaces), it is substituted to ", " (with a space).
Also, if the text entered as "&" (no spaces) it is substituted to " & " (with spaces). These are common errors that lead to rejected edits that would be correct otherwise.

Component/s Edit system [ 10001 ]
Component/s JavaScript [ 10021 ]
Component/s Release editor [ 10002 ]
voiceinsideyou made changes - 20/Sep/11 03:45 PM
Link This issue is related to MBS-3388 [ MBS-3388 ]
Oliver Charles made changes - 18/Nov/11 05:18 PM
Assignee Oliver Charles [ acid2 ]
Nicolás Tamargo added a comment - 28/Dec/11 01:53 PM

Same for " feat. " too. On the other hand, if we're adding a smart filter, it would be handy if it stopped adding a space for "ga"


Václav Brožík added a comment - 18/Jan/12 11:29 PM

I agree that this could be useful for inexperienced editors but the solution must not disallow entering join phrases without spaces.


Oliver Charles added a comment - 15/Aug/12 01:37 PM

Oliver Charles made changes - 15/Aug/12 01:37 PM
Due Date 2012-11-14 00:00:00.0
Fix Version/s Within 3 months [ 10115 ]
Oliver Charles made changes - 15/Aug/12 02:50 PM
Status Open [ 1 ] Review Submitted [ 5 ]
Oliver Charles made changes - 15/Aug/12 02:50 PM
Assignee Oliver Charles [ acid2 ]
Oliver Charles added a comment - 15/Aug/12 02:50 PM

Oliver Charles made changes - 15/Aug/12 02:50 PM
Fix Version/s Bug fixes, 2012-09-03 [ 10151 ]
Fix Version/s Within 3 months [ 10115 ]
Oliver Charles made changes - 20/Aug/12 11:47 AM
Status Review Submitted [ 5 ] In Beta Testing [ 10002 ]
Oliver Charles made changes - 03/Sep/12 10:34 AM
Status In Beta Testing [ 10002 ] Closed [ 6 ]
Resolution Fixed [ 1 ]