[#MBS-3476] Add more string substitutions for "join phrase" - MusicBrainz JIRA

MusicBrainz Server

Add more string substitutions for "join phrase"

Created: 20/Sep/11 02:46 PM Updated: 03/Sep/12 10:34 AM Due: 14/Nov/12 Resolved: 03/Sep/12 10:34 AM

Component/s:

Edit system, JavaScript, Release editor

Affects Version/s:

None

Fix Version/s:

Bug fixes, 2012-09-03

Issue Links:

Relates

This issue is related to:

MBS-3388 "Guess artist credits" - automation support for RFC-327 and moving feats etc to artist-credits

Description

« Hide

When adding more than one artist to a track, one must enter " & " or ", " (with the spaces).

If one adds "," or "&" (no spaces) the Artist field does not render properly (i.e. without spaces).

I am suggesting adding logic so that if the join phrase is entered as "," (no spaces), it is substituted to ", " (with a space).
Also, if the text entered as "&" (no spaces) it is substituted to " & " (with spaces). These are common errors that lead to rejected edits that would be correct otherwise.

Sort Order:

[ Permalink | « Hide ]

voiceinsideyou added a comment - 20/Sep/11 03:45 PM

Getting the correct number of spaces around join phrases is indeed quite annoying; and possibly could be corrected automagically for many cases. Perhaps this could be part of the "guess artist credits" component I suggest in MBS-3388.

[ Permalink | « Hide ]

Nicolás Tamargo added a comment - 28/Dec/11 01:53 PM

Same for " feat. " too. On the other hand, if we're adding a smart filter, it would be handy if it stopped adding a space for "ga"

[ Permalink | « Hide ]

Václav Brožík added a comment - 18/Jan/12 11:29 PM

I agree that this could be useful for inexperienced editors but the solution must not disallow entering join phrases without spaces.

[ Permalink | « Hide ]

Oliver Charles added a comment - 15/Aug/12 01:37 PM

Agreed to fix within 3 months by http://chatlogs.musicbrainz.org/musicbrainz-devel/2012/2012-08/2012-08-14.html

[ Permalink | « Hide ]

Oliver Charles added a comment - 15/Aug/12 02:50 PM

In review with http://codereview.musicbrainz.org/r/2172/