|
Yeah, confirmed for auto-created release groups, release titles and track titles on release editor. Ok, these issues are only caused by the release editor, and that's because it uses the form system in a slightly different way. At the moment, the release editor uses exactly what you typed, and inserts that. The other forms use a cleaned value of what you've typed, but the release editor doesn't seem to use these cleaned values. So there are 2 options: 1. Fix the release editor to use the cleaned values, not the users direct input. I don't like 2, because it's only half way to what it's really trying to express, which is that names must never start or end with a space, and never have multiple spaces. If this is truly what we want, then this should be handled at the database level (triggers, checks, and what not). So I'm making this decision required to see how far we want to clean this data up. I like the long term solution of 2 (pushing stuff) to the DB, because I trust database code more than I trust the Perl code, but it does mean a minor semantic change as to practical data type of artist_name.name and friends. I think this should be fixed in the release editor. Option 2 has interesting semantic implications that we may not want. As a note, this bug also allows the creation of such things as release groups with no visible name: http://musicbrainz.org/edit/15637494 As this issue has been delayed, I am moving it back to be rescheduled. |
||||||||||||||||||||||||||||||||||
It doesn't look like this was really fixed. I still see titles with trailing spaces being added, e.g. the one I fixed with http://musicbrainz.org/edit/15355798
.