Issue Details (XML | Word | Printable)

Key: MBS-3356
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Kuno Woudt
Reporter: Paul Taylor
Votes: 4
Watchers: 3
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Seeded add release (copied from existing release) doesnt link tracks to recordings of copied release

Created: 26/Aug/11 06:01 PM   Updated: 08/Dec/11 04:19 PM   Resolved: 08/Dec/11 04:19 PM
Component/s: Release editor
Affects Version/s: None
Fix Version/s: Bug fixes, 2011-12-05

Issue Links:
Relates
 


 Description  « Hide

When you add a new release and select to base it on another release I assumed that it would then link to the recordings of the selected release but it doesnt, you have to manually link each track to the required recording, which as well as being time consuming is sometimes impossible to do accurately.

I dont know if this was design or not, but if it was there should at least be an option to link to all the recordings of the selected release.



Sort Order: Ascending order - Click to sort in descending order
Aurélien Mino added a comment - 26/Aug/11 10:20 PM

Anyone monitoring Jira and allowed to set priority and milestone, please make this important: it used to work, so this a regression, and Paul is at least the second user encountering this behavior.


Johannes Weißl added a comment - 27/Aug/11 02:21 AM

Hmm? This does work for me (tried just today!). I've experienced this bug only when using the "Discogs import userscript".


Paul Taylor added a comment - 27/Aug/11 07:45 AM

You are right I was using the Discogs Import Userscript, so the problem must be to do when seeding the data but that doesnt mean there isnt a problem.


voiceinsideyou added a comment - 28/Aug/11 02:55 AM

Aurélien - are you saying this used to work with the Discogs Import userscript, or just in general?


Aurélien Mino added a comment - 28/Aug/11 08:02 PM

I was just saying this used to work in general (at the time of my last comment we were not aware that is was related to seeding of release editor with parameters).


Kuno Woudt added a comment - 07/Dec/11 07:35 PM

Reproduced this on the current server, using with the following steps:

1. install murdos' import script from http://userscripts.org/scripts/show/36376
2. go to http://www.discogs.com/release/1482417
3. click "Import into MB"
4. click search icon in release artist to make sure Thom Yorke is correctly identified as the Thom Yorke in our database
5. click Next (three duplicates are found)
6. select one of the existing tracklists and click Next
7. click Next

No recordings are selected, it seems to use the seeded tracklist over the tracklist selected on the duplicates tab.


Paul Taylor added a comment - 07/Dec/11 09:04 PM

If you try the test case again but select the 3 track release I think the problem is clearer.
The tracklist page lists just three tracks (rather than the nine in the seeded release), but when you go to the Recordings tab you see that even though you have elected to based release on existing release for each track it doesnt link to the existing recording, but to 'add a new recording', surely make sense to link to existing recording.

But this use case, also shows a more serious problem:
The tracklist page shows three tracks, but the recordings page shows nine tracks, although it has lost the artist and title information.

Im not sure whether in this case it should show nine tracks, or three tracks but clearly should be consistent. My preference would be it shows nine tracks, with the first threee tracks replaced by the release we selected to base it on, and the other six tracks untouched.


Kuno Woudt added a comment - 07/Dec/11 09:32 PM

I added a fix for the issue as I described it in master as commit 121294d529fa138c64c803e01c5414d3a2475604.

But I believe that fix doesn't solve the issue as it was described by Paul in the previous comment, so I'm not closing this ticket.
.


Kuno Woudt added a comment - 08/Dec/11 04:19 PM

In my tests it now selects the actual tracklist from the Duplicates tab, throwing away any seeded tracks. IMO this is correct behaviour, and the bug as described in the ticket is fixed now.

I can understand that you would like additional seeded tracks to show up in the tracklist, it sounds useful in some cases (adding a release with a bonus track), but it also sounds potentially confusing. In any case, I suggest a separate ticket should be opened for that.