Issue Details (XML | Word | Printable)

Key: MBS-3152
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Kuno Woudt
Reporter: Lukáš Lalinský
Votes: 3
Watchers: 4
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Tracklist duplication with sub-second track duration differences

Created: 03/Aug/11 05:38 AM   Updated: 02/Dec/11 05:41 PM   Resolved: 02/Dec/11 05:41 PM
Component/s: Edit system
Affects Version/s: None
Fix Version/s: Bug fixes, 2011-12-05

Issue Links:
Depends
 
Relates
 


 Description  « Hide

I edited http://musicbrainz.org/release/218cecee-c862-39ce-bbb2-25e0bad1a6c4 and added a new medium by selecting the tracklist from http://musicbrainz.org/release/eaf48a41-0137-4979-8ff8-aa93de879a40. It seems that it resulted in duplicate tracklists:

http://musicbrainz.org/tracklist/1108286
http://musicbrainz.org/tracklist/31938

The tracklist shouldn't have been duplicated, the medium should just link to the old tracklist.



Sort Order: Ascending order - Click to sort in descending order
voiceinsideyou added a comment - 03/Aug/11 06:00 PM

Seems important?


Johannes Weißl added a comment - 03/Aug/11 06:57 PM

Hmm, I got the impression that track lists are through away material anyway... it's not that anything is gained if the same one would be used. As soon as you edit one, a new one is created. Or am I wrong?


Lukáš Lalinský added a comment - 03/Aug/11 07:05 PM

Identical tracklists are supposed to be automatically reused.


Oliver Charles added a comment - 03/Aug/11 07:57 PM

You are correct, hrglgrmpf, but there should not be duplicates.


Johannes Weißl added a comment - 03/Aug/11 08:03 PM

Ok, thanks for the explanation! So this is mostly a database specific bug and will not change edit behavior in any way if fixed...


Ger added a comment - 04/Aug/11 08:27 AM

So to check if I am understanding correctly: the intended functionality, is that tracklists be split automatically if an edit is made to one release?

If so, it seems like it would be better if a tracklist could be locked, so as not to split on such edits: they would be made to the tracklist itself, and cascade. It seems very messy to have releases with identical tracklists being allowed to maintain different database tracklists. If there was a mistake in the original, it has to be changed multiple times (some of which could fail etc. etc.)


Johannes Weißl added a comment - 04/Aug/11 08:48 AM

@Ger: I also thought about that... I wonder however if it is technically possible (not too hard), and what the UI for such a feature should be...


Oliver Charles added a comment - 04/Aug/11 09:30 AM

Ger: The plan is to have that as an option when editing the medium, at the moment that option is assumed to be "edit this tracklist independently"



voiceinsideyou added a comment - 06/Aug/11 07:42 AM

Lukáš Lalinský added a comment - 07/Aug/11 01:38 PM

Ok, so the problem are subsecond track durations. The release editor is only able to store seconds, so if you load a tracklist that has durations set by a CD TOC, the release editor will round them to the nearest second, which will no longer match the original tracklist.

I can see these possible options:

1) Make the release editor capable of storing milliseconds. This seems like a lot of work for very little benefit.

2) Round all track durations to the nearest second and start storing them as seconds in the next schema change.

3) Ignore the problem for now and start storing durations as seconds in the next schema change.

Regardless of the choice, I think I'd prefer to change the tracklist page to show all releases that have tracklists with the same recordings, not necessarily the same track durations or even track titles. That would make tracklists even more "anonymous" objects, but I think it's not big loss.



Johannes Weißl added a comment - 29/Nov/11 10:37 PM

I have two tracklists:
http://musicbrainz.org/tracklist/1151436
http://musicbrainz.org/tracklist/556552

where I set the durations via the same disc id, but they are not merged. Is this related to this bug, or a new bug?


Oliver Charles added a comment - 29/Nov/11 10:44 PM

Call it a new bug for now and relate it to this ticket please


Johannes Weißl added a comment - 29/Nov/11 10:50 PM

Done, see MBS-3858


Kuno Woudt added a comment - 02/Dec/11 05:41 PM

commit 0c3a78bee3519fb3ce39d9afe967a42a873c284c