Issue Details (XML | Word | Printable)

Key: MBS-3135
Type: Sub-task Sub-task
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Ian McEwen
Reporter: patate12
Votes: 4
Watchers: 2
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server
MBS-390

Predefined edit URL should be redirect/converted to standard edit searches

Created: 01/Aug/11 10:03 AM   Updated: 02/Apr/13 09:08 AM   Resolved: 17/Sep/12 10:29 AM
Component/s: Edit system, Search
Affects Version/s: None
Fix Version/s: 2012-09-17

Issue Links:
Relates
 


 Description  « Hide

Let's say I click a user's edits, I see all his/her edits or her open edits.
I then used to begin to filter down the edits to progressively only see the wanted edits.
It is now impossible to begin filtering edits starting from a generic edit search page (entity/mbid/[open_]edits). ← the solution to this would be that clicking user/bob/edits/open would redirect to the appropriate complete detailed search URL (it was how it was done before) and same for /entity/mbid/open_edits → complete search URL ...

So that we can see current search criteria on top page

PS. Notice the inconsistency between /user/bob/edits/open and /entity/mbid/open_edits



Sort Order: Ascending order - Click to sort in descending order
Oliver Charles added a comment - 01/Aug/11 12:19 PM

Good suggestion, I plan to actually make all these little searches use the same edit search system, so this is certainly something I plan to add in


nikki added a comment - 09/Oct/11 03:11 PM

I disagree with redirecting because (unlike before) the custom search page always shows the form and I don't think people should be shown the custom search fields unless they actually want to do custom/advanced searches. I also really like how the current predefined searches have useful page titles (e.g. "Edits for Some Artist") and links in the title back to the entity in question. The custom searches have nothing like that, it just says "Search for Edits" in the title.

I do completely agree that it should be a lot easier to switch from the predefined searches to custom searches though. It's really annoying how there's no way to switch to a custom search at all.


voiceinsideyou added a comment - 10/Oct/11 02:35 AM

Agree with nikki here re: redirect. Also agree that it is indeed super-annoying that there's no easy way to filter an editor/artist/release's edits for those of a particular type (for example) so we need some sort of solution


patate12 added a comment - 10/Oct/11 07:18 AM

So you prefer to have an auto-generated link called Advanced search that goes to the auto-generated equivalent URL instead of forwarding directly to this one.


patate12 added a comment - 10/Oct/11 07:24 AM

My edits also asked for common URL base for all searches.
We have /search/edits*, /edit/subscribed*, /edit/subscribed_editors, /user/bob/edits*, /release/mbid/edits*, /release/mbid/open_edits*, /artist/mbid/edits*, /artist/mbid/open_edits*, etc.
I thought it would be more convenient (for stuff like scripting and such) that they all begin the same as /search/edits* or /search*.


voiceinsideyou added a comment - 10/Oct/11 09:52 AM

Something like "Advanced Search", yeah - maybe "Customise this search" perhaps.


nikki added a comment - 10/Oct/11 10:27 AM

I like "Customise this search". It doesn't necessarily have to load a new page either, it could just load the custom search within the existing page when someone clicks on it.


Ian McEwen added a comment - 23/Jul/12 04:49 PM

Subscribed entities actually can't be done with edit search – you'd need '(artist is in my subscriptions OR label is in my subscriptions) AND status is open' and you can only choose conceptual AND or OR – no mixing.

Subscribed editors can't either, because we don't have a subscribed editors filter.


Ian McEwen added a comment - 23/Jul/12 05:53 PM

http://codereview.musicbrainz.org/r/2083/ covers everything except subscribed entities/subscribed editors, that as mentioned can't be done.


patate12 added a comment - 24/Jul/12 07:21 AM - edited

Woaw ! Thanks very much I'm really eager to see this live !

About the redirect, nikki and voice, maybe you see a problem with client-side redirect indeed it's clumsy but wouldn't it be ultra-awesome to have a server-side redirect ?!

Either server-side redirect or HTTP 302 (like chatlogs' today link) redirect from nice URL to search URL would allow

  • fancy URL display in website links as now (the stuff you want to keep) and manipulation by user (right click copy URL, etc.)
  • no two pages loaded, only one (send user in full search context in one go, where the current patch makes the user have to click twice before being there)

Ian McEwen added a comment - 14/Aug/12 03:04 AM

Putting in 09-03 fix version based on the assumption comments on codereview will get responded to.


Oliver Charles added a comment - 29/Aug/12 10:12 AM

Moving to the next release as we're in freeze now.


patate12 added a comment - 03/Sep/12 11:39 AM

Hey I just saw that new Refine this search on beta, it's excellent, Ian !