Issue Details (XML | Word | Printable)

Key: MBS-2944
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Oliver Charles
Reporter: patate12
Votes: 1
Watchers: 3
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Vote on all edits control should only be shown to auto-editors

Created: 04/Jul/11 08:47 AM   Updated: 21/Sep/11 01:53 PM   Resolved: 14/Sep/11 02:14 PM
Component/s: Edit system
Affects Version/s: None
Fix Version/s: Bug fixes, 2011-09-19


 Description  « Hide

Bug description

I RANDOM see a "Vote on all edits" html batch vote block with radio buttons appearing on top of some edit list pages (but it depends the statuses and sometimes it's often, sometimes it's rare).
Sometimes even when such a batch vote thing wouldn't be needed (only one votable edit for instance).

I am not automod so I guess it's something from automod world that randomly burst out.

Further reading related to such a feature if it would come to existence.

This actually doesn't officially exist for non automods.
It would be such a nice tool that I wrote such a check all votes, back in 2009.

Since 2009, several enhancements have been added by experience.
Here they are in case it is decided to deploy this tool for non automods, they could be a good set of enhancements for official final version too.

  1. Don't use radio buttons, use buttons (as the radio status will be incoherent after vote adjusts)
  2. Add it to ALL needed pages (more than one votable edit) ONLY
  3. Make it trigger the click event (compatibility with other userjs like nikki's colours)
  4. Make it NOT vote on already voted edits (except if user forces it with SHIFT+CLICK)
  5. Add a reset button that reverts votes to their initial state at page loading time


Sort Order: Ascending order - Click to sort in descending order
patate12 added a comment - 06/Sep/11 01:33 PM

This bug has been fixed by Check all votes ver. 2011-09-06_1500.


Oliver Charles added a comment - 13/Sep/11 04:00 PM

I'm afraid I don't understand this ticket, could you clarify it for me? As far as I know, it behaves like it did on the classic server.


patate12 added a comment - 14/Sep/11 01:57 PM

I tried to re-write the description so that to be more understandable, please have a look.
Now I know that, if I see it again I rty to remember to catch you somewhere to show you (I temp. deactivated my bug fix).


Oliver Charles added a comment - 14/Sep/11 02:07 PM

Ah, you're not an auto-editor. That would explain things, as this is only available to auto-editors (or is meant to be!)


Oliver Charles added a comment - 14/Sep/11 02:08 PM

With regards to your script/enhancements - I like the sound of it, but I've opened a new ticket for that and further discussion MBS-3435


Oliver Charles added a comment - 14/Sep/11 02:14 PM

Fixed with b751ddb76b1432a06d77ba412d840625be32f11a


patate12 added a comment - 14/Sep/11 02:23 PM

What's b751ddb76b1432a06d77ba412d840625be32f11a ?
You've eventually spotted a glitch that was causing this stuff to appear in some circumstances ?
If so, I don't need to look for it any more, do I ?
Thanks



patate12 added a comment - 21/Sep/11 01:53 PM

Olivier eventually found out it was buggy showing on work edit pages with open edits.