[#MBS-2817] Add Missing Entities not displaying correct search results for many artists - MusicBrainz JIRA

MusicBrainz Server

Add Missing Entities not displaying correct search results for many artists

Created: 19/Jun/11 04:39 PM Updated: 14/Oct/11 07:09 PM Resolved: 24/Aug/11 07:10 PM

Component/s:

Release editor, Search

Affects Version/s:

None

Fix Version/s:

Bug fixes, 2011-09-12

File Attachments:

None

Image Attachments:

1. AME-no-matches-0.PNG
(88 kB)

2. AME-no-matches-1.PNG
(84 kB)

Issue Links:

Duplicate

This issue is duplicated by:

~~MBS-2571~~ Internal Server Error with no details when adding on tracks to existing (multi-disc) release

Relates

This issue is related to:

~~MBS-2564~~ "Add Missing Entities" tab in add release does not search for Artist Aliases when trying to find Artists

~~MBS-2467~~ RE: Add Missing Entities problems with caps

This issue has related issue:

~~MBS-3635~~ Internal server error when adding a release "No artists was created for foo"

~~MBS-2794~~ Cannot enter Release: Internal Server Error

~~MBS-3127~~ Poor label search results in the release editor

Resolution

This issue resolves:

~~MBS-2778~~ Internal Server Error when creating new VA release involving new artist creation

~~MBS-3208~~ Trim leading/trailing whitespace in release editor prior to Add Missing Entities check

Description

« Hide

While adding the tracklist at http://tickets.musicbrainz.org/secure/attachment/10215/tracklist.txt using fmi's instructions from separate issue ~~MBS-2778~~:

1. Use "Add various artists release"
2. Check VA checkbox - use any title
3. Paste track list from the attached file (as is)
4. Click straight to Add missing entities

Among others, it complains to me about the artists Justine, Greed, Alex Party, Winx* - ALL of which have either exact matches in the DB or easily searchable matches. The interface basically forces me to add duplicate artists; not displaying any of the trivial matches.

Justine: http://musicbrainz.org/search?query=justine&type=artist
Greed: http://musicbrainz.org/search?query=greed&type=artist
Alex Party: http://musicbrainz.org/search?query=Alex+Party&type=artist
Winx*: http://musicbrainz.org/search?query=Winx*&type=artist

Why is AME not finding obviously matching entities? Aside from ~~MBS-2467~~ and ~~MBS-2564~~ that is...

If you click through to actually enter the edit (with all the add artists) it gives you an ISE; I'm guessing this is probably because it's violating dupe artists constraints with no comment, but test is currently broken so I can't see the full error.

Sort Order:

[ Permalink | « Hide ]

voiceinsideyou added a comment - 26/Jul/11 04:45 PM

Any chance of looking at this for the upcoming release? I'd like to emphasise that this leads to incorrect data entry and dupe artists being added, since the UI gives you no choice and does not present correct artist search results.

This will be leading to many duplicate artists being entered and extremely painful maintenance in future.

[ Permalink | « Hide ]

voiceinsideyou added a comment - 11/Aug/11 02:11 AM

This will be great to have sorted. Is this one for which you're pretty confident in the fix, warp? Or needs lots intricate testing?

[ Permalink | « Hide ]

Kuno Woudt added a comment - 15/Aug/11 04:56 PM

merged into master, commit c867166ed578e3feade53992ffd66eeb60b0e857

[ Permalink | « Hide ]

Nicolás Tamargo added a comment - 16/Aug/11 04:52 PM

Not fixed for labels

[ Permalink | « Hide ]

voiceinsideyou added a comment - 16/Aug/11 05:06 PM

This ticket did not mention labels; is there another ticket for that?

[ Permalink | « Hide ]

Oliver Charles added a comment - 17/Aug/11 11:20 AM

According to the review it was due more work about labels too.

[ Permalink | « Hide ]

Kuno Woudt added a comment - 23/Aug/11 02:47 PM

The "Missing Entities" page did not display the correct results because the artists/labels were not trimmed, so it was searching in the database for things like "The Prodigy " (note the trailing space). I fixed this problem for artists, but forgot to do so for labels – the ticket doesn't mention this, but it is the same issue.

[ Permalink | « Hide ]

Kuno Woudt added a comment - 24/Aug/11 07:10 PM

fixed for labels as well, committed to master as commit fc3d8834021a90a6f543fabe8b624aacbb3c75b3