[#MBS-2781] New behavior of "Move CDToc" edit is confusing - MusicBrainz JIRA

MusicBrainz Server

New behavior of "Move CDToc" edit is confusing

Created: 16/Jun/11 04:58 PM Updated: 19/Feb/12 01:42 PM Resolved: 10/Aug/11 11:35 AM

Component/s:

Edit system

Affects Version/s:

Bug fixes, 2011-06-13

Fix Version/s:

Bug fixes, 2011-08-15

Description

« Hide

http://codereview.musicbrainz.org/r/1276/

I entered a "Move CDToc" edit while cdtoc already exists on target medium.
Then I've received a mail from Modbot telling me "This CDTOC cannot be moved to So80s 5, as it already has this CDTOC. It must instead be removed."
Judging by the tone of the last sentence, I was sure the edit had failed.

But the edit was in fact open...

Sort Order:

voiceinsideyou made changes - 17/Jun/11 05:21 AM

Field	Original Value	New Value
Affects Version/s		Bug fixes, 2011-06-13 [ 10078 ]
Component/s		Edit system [ 10001 ]

Robert Kaye made changes - 24/Jun/11 12:41 AM

Fix Version/s

Bug fixes, 2011-07-04 [ 10080 ]

[ Permalink | « Hide ]

Oliver Charles added a comment - 30/Jun/11 11:37 AM

If I change it to the following message, will it be clearer?

"This CDTOC cannot be moved to So80s 5, as it already has this CDTOC. A remove CDTOC edit has instead been entered"

[ Permalink | « Hide ]

Aurélien Mino added a comment - 30/Jun/11 12:20 PM

I personally much prefer the pre-NGS behavior, where moves silently delete the disc from the source.
It's more intuitive.

Oliver Charles made changes - 05/Jul/11 07:46 PM

Fix Version/s		Schema Change, 2011-07-11 [ 10081 ]
Fix Version/s	Bug fixes, 2011-07-04 [ 10080 ]

Oliver Charles made changes - 13/Jul/11 01:16 AM

Fix Version/s		Bug fixes, 2011-07-18 [ 10082 ]
Fix Version/s	Schema Change, 2011-07-11 [ 10081 ]

Oliver Charles made changes - 18/Jul/11 10:21 PM

Fix Version/s		Bug fixes, 2011-07-25 [ 10083 ]
Fix Version/s	Bug fixes, 2011-07-18 [ 10082 ]

Oliver Charles made changes - 25/Jul/11 08:59 PM

Fix Version/s		Bug fixes, 2011-08-01 [ 10084 ]
Fix Version/s	Bug fixes, 2011-07-25 [ 10083 ]

Oliver Charles made changes - 02/Aug/11 09:02 PM

Fix Version/s		Bug fixes, 2011-08-08 [ 10086 ]
Fix Version/s	Bug fixes, 2011-08-01 [ 10084 ]

Oliver Charles made changes - 05/Aug/11 01:14 PM

Status

Open [ 1 ]

Review Submitted [ 5 ]

Oliver Charles made changes - 09/Aug/11 06:08 PM

Fix Version/s		Bug fixes, 2011-08-15 [ 10087 ]
Fix Version/s	Bug fixes, 2011-08-08 [ 10086 ]

Oliver Charles made changes - 10/Aug/11 11:35 AM

Status	Review Submitted [ 5 ]	Closed [ 6 ]
Resolution		Fixed [ 1 ]

[ Permalink | « Hide ]

Aurélien Mino added a comment - 19/Feb/12 01:42 PM

For reference, related code review: http://codereview.musicbrainz.org/r/1453/