|
Sort Order:
(Thinking outloud) The reason this fails is because when a recording is merged, the tracklist is updated with new recording IDs. When the edit is applied, the tracklist is compared to the tracklist as it looked when the edit was entered, and determined to have changed, thus the edit fails. To allow the edits to be applied, it needs to determine that the tracklist is the same. The best way to do this is to record the recordings GID, rather than the ID, and make sure at application time everything resolves to the same recording ID. This is going to need:
Should we try and upgrade current edits? Maybe just edits that are open? Won't make todays release Decision required as I'd like to discuss this more before work. My vote: upgrade all edits. And BTW I never understood why MBIDs were not used in edits... Related to Merging artists also breaks medium edits Unless it's editing Medium 1 that caused Medium 2 to fail Hopefully that decision comes quickly. Giving this ticket a bit more priority by setting "Fix version", as briefly discussed on irc. I'm curious, since I vastly improved how the "edit medium" edit was applied, is this still an issue? Alex: Please comment on this soon. Otherwise we'll close it as a won't fix. I think this has been fixed with some of the other changes, so I'll close it as Fixed and reopen if necessary. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Bug
Closed
Major
merging recordings shouldn't kill release edits
It's a really annoying issue, let's take an example:
- the editor has chosen to create new recordings for all tracks.
A release is being added in http://musicbrainz.org/edit/14605091
But at least one recording was in fact already in database: http://musicbrainz.org/recording/3826afa7-b1df-488b-a440-32cd00b5304f
I think today we have not other choice than merging new dupes and existing recordings.
But if I do it now, the add medium will fail.
And if I had to wait 2 weeks for the edit to be accepted, I won't do it, because I'd already forgotten (and I don't want to manage a huge TODO list...).