[#MBS-2709] editing release artists should not kill tracklist edits - MusicBrainz JIRA

MusicBrainz Server

editing release artists should not kill tracklist edits

Created: 11/Jun/11 12:42 AM Updated: 14/Jul/11 04:45 PM Resolved: 14/Jul/11 12:29 PM

Component/s:

Edit system

Affects Version/s:

Bug fixes, 2011-06-13

Fix Version/s:

Schema Change, 2011-07-11

Issue Links:

Relates

This issue is related to:

~~MBS-2710~~ merging recordings shouldn't kill release edits

This issue has related issue:

~~MBS-2739~~ The tracklist has changed since this edit was created

Description

« Hide

http://musicbrainz.org/edit/14521966 failed because modbot thinks the tracklist was changed.

I think it was this edit: http://musicbrainz.org/edit/14521964 that caused it to fail.

Both edits were created at once via the release editor, so that shouldn't happen.

Sort Order:

[ Permalink | « Hide ]

Paul Taylor added a comment - 11/Jun/11 07:58 AM

One for you perhaps.

[ Permalink | « Hide ]

patate12 added a comment - 19/Jun/11 07:58 PM

It's so upsetting for us non automods having to redo tracklist edits 4 or 5 times !!!!

[ Permalink | « Hide ]

voiceinsideyou added a comment - 20/Jun/11 12:51 AM

It's upsetting for us having to vote on all these edits so carefully and see such mess in edit histories...

[ Permalink | « Hide ]

Oliver Charles added a comment - 14/Jul/11 12:29 PM

It's upsetting for me to see my code upset people, don't worry I believe the changes to ModBot have mostly fixed this, however:

If you change track artists in an edit release edit, and edit track artists in an edit medium edit, you're probably going to cause a conflict. I don't think this can really be prevented, because you are asking for 2 edits that do 2 different things. If the artist matches the 'change track artists' edit though, no conflict will happen.

[ Permalink | « Hide ]

voiceinsideyou added a comment - 14/Jul/11 04:45 PM

I think that's a fair enough optimistic lock fail.