[#MBS-2487] Cancelling an add relationship edit doesn't update cover art - MusicBrainz JIRA

MusicBrainz Server

Cancelling an add relationship edit doesn't update cover art

Created: 02/Jun/11 08:50 AM Updated: 02/Aug/11 09:26 AM Resolved: 02/Aug/11 09:26 AM

Component/s:

None

Affects Version/s:

None

Fix Version/s:

Bug fixes, 2011-08-01

Issue Links:

Relates

This issue is related to:

~~MBS-2310~~ Cover art should show up immediately

Description

« Hide

If an add relationship edit is cancelled, any cover art it provided should be removed (and if there's another cover art link that can be used, it should use that)

Sort Order:

[ Permalink | « Hide ]

Oliver Charles added a comment - 27/Jul/11 03:59 PM

This is now available for testing on http://test.musicbrainz.org

[ Permalink | « Hide ]

voiceinsideyou added a comment - 27/Jul/11 04:07 PM

This does not appear to be working on test for one reason or another.

Both rejecting in http://test.musicbrainz.org/edit/14841071 and cancelling http://test.musicbrainz.org/edit/14841072 lead to the edit being "Error: This edit failed due to an internal error and may need to be entered again." which is even worse?

[ Permalink | « Hide ]

Oliver Charles added a comment - 27/Jul/11 04:12 PM

Indeed, that doesn't sound good! I can't reproduce it here, but I'll explore more tomorrow when I'm back at work.

[ Permalink | « Hide ]

Oliver Charles added a comment - 28/Jul/11 11:26 AM

Ok, this has been fixed. There was a tiny little bug when removing the very last CA relationship for releases that didn't have a barcode, and it seems that wasn't in my test cases. This should be working now!

[ Permalink | « Hide ]

voiceinsideyou added a comment - 28/Jul/11 05:00 PM

Looks good now. Does the barcode affect it somehow? Didn't really even consider that!

[ Permalink | « Hide ]

Oliver Charles added a comment - 29/Jul/11 12:16 PM

Yea, we now use barcodes to lookup Amazon cover art too