Issue Details (XML | Word | Printable)

Key: MBS-2196
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Oliver Charles
Reporter: nikki
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Can't delete unused relationship type

Created: 21/May/11 08:22 PM   Updated: 14/Oct/11 04:42 PM   Resolved: 14/Oct/11 04:42 PM
Component/s: Edit system, Misc features
Affects Version/s: None
Fix Version/s: Bug fixes, 2011-10-10

Issue Links:
Depends
 


 Description  « Hide

After editing a couple of relationships added because of MBS-2195, I tried to remove the unnecessary and confusing "covers and versions" work-work type (which used to be used for grouping, but since there's only two work-work relationships, right now it's more confusing than useful)

Even though my database is showing no relationships using the type, I get an internal server error when trying to delete it.



Sort Order: Ascending order - Click to sort in descending order
Oliver Charles added a comment - 14/Sep/11 11:39 AM

I created a new relationship type, and then immediately removed it, and it worked just fine. Evidently, that relationship type must have still been in use. If you still have that data around, let me know on IRC and I'll explain how to get a better bug report.


nikki added a comment - 07/Oct/11 03:18 PM

I still can't remove the "covers and versions" work-work relationship type.

I now also can't remove the "score" release group-url relationship type (the proposal to remove it passed).

My replicated database is showing no relationships for these two:

musicbrainz=# select lww.entity0 from l_work_work lww, link l, link_type lt where lww.link=l.id and l.link_type=lt.id and lt.name = 'covers and versions';
entity0
---------
(0 rows)

musicbrainz=# select lrgu.entity0 from l_release_group_url lrgu, link l, link_type lt where lrgu.link=l.id and l.link_type=lt.id and lt.name = 'score'; entity0
---------
(0 rows)

musicbrainz=#


Oliver Charles added a comment - 12/Oct/11 02:35 PM

Ok, the problem is link rows exist, but they don't have any l_release_group_url rows. So as far as you're concerned, the relationship doesn't exist, but as far as the admin system is concerned, there are relationships in existance. The review at http://codereview.musicbrainz.org/r/1584/ should sort that out, by removing these redundant link rows and ensuring they never exist.