Issue Details (XML | Word | Printable)

Key: MBS-2126
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Kuno Woudt
Reporter: Paul Taylor
Votes: 13
Watchers: 7
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Release Editor response times are unacceptable

Created: 20/May/11 08:13 AM   Updated: 25/Sep/11 03:57 AM   Resolved: 25/Sep/11 03:56 AM
Component/s: Release editor, User interface
Affects Version/s: Hot fixes, 2011-05-27
Fix Version/s: Bug fixes, 2011-07-18

Issue Links:
Duplicate
 
Relates
 


 Description  « Hide

Release Editor response times are too slow, making it annoying to use.

Please profile the release editor to find out what is actually taking up the cpu time.



Sort Order: Ascending order - Click to sort in descending order
Aurélien Mino added a comment - 20/May/11 08:17 AM

I can't agree more.
Each time I just want to edit a simple things like e.g. a medium title, I'm annoyed because it means I'll have to open the release editor...


voiceinsideyou added a comment - 04/Jun/11 02:21 PM

Is there anything happening on this or MBS-1607? It's still basically impossible to add many VA releases (and forget about adding a multi-disc one in one go!) due to timeouts on the "add missing entities" page. Possibly there's another ticket somewhere I've missed.


nikki added a comment - 06/Jun/11 01:25 AM

I spent ages trying to add a 35 track v.a. release... even though I didn't need to add any new entities, I still couldn't get to the end of the release editor without getting 502s and eventually had to give up. :/


voiceinsideyou added a comment - 06/Jun/11 12:20 PM

Indeed - it's literally impossible to add/edit VA releases (my guess from experimentation is > 20 tracks) without getting such timeouts.


Robert Vollmert added a comment - 15/Jun/11 04:42 PM

Just to note that since yesterday, I've been able to successfully edit and add large various artist releases. So it seems this has been fixed?


Paul Taylor added a comment - 15/Jun/11 06:25 PM

That particular issue has been fixed http://tickets.musicbrainz.org/browse/MBS-2347 however the release editor as a while is still extrremly sluggish whatever you are doing.


voiceinsideyou added a comment - 17/Jun/11 05:08 AM

Yeah, unfortunately both this and MBS-1607 are probably too generic and thus difficult to close. I guess it probably needs analysis/profiling by devs and then being broken down into more achievable sub-tasks or tickets which can actually be closed one-by-one based on their priority/ROI


Kuno Woudt added a comment - 13/Jul/11 05:36 PM

I've removed a bunch of unnecessary queries and form initializing from the code. This has been merged into master in commit 54acfed1c99f07c6c9d163978992cbcc48b33da4 and will be part of the next release.

Until the release, please help in testing these changes on http://test.musicbrainz.org.

If release editor still has performance issues after these changes have been deployed on the production servers, please re-open this ticket.


MLL added a comment - 24/Sep/11 01:35 PM

OK, it seems the problem I'm facing realtes to this ticket.

Unpon trying to add a big V.A. relase ( http://www.discogs.com/Various-100-Tubes-Dance-2010/release/2488476 ), I get "502 Bad Gateway nginx/0.7.65" while, on the Recordings tab, I press "Next".

Then, on the tracklist tab, I used the ajax search function to get to about 70% of the artists on green background, but the problem persist.


voiceinsideyou added a comment - 25/Sep/11 03:56 AM - edited

This ticket was an older ticket referring to a more generic problem which doesn't really exist in the same way now. I don't think it's helpful to re-open it - it had limited use to begin with. I've created MBS-3522 instead.

The workaround that worked for me was to lock down all the artists/credits in the advanced editor first.