Rob, please read the discussion on the Trac page, and let me know if you want this implemented
Seeing as Rob requested that annotations be searchable from the webservice
it wouldn't make sense to not allow a lookup of an annotation.
Yes, I want to see this implemented (post NGS). I don't think it makes sense to hide any part of our data from the WS. Clearly there needs to be an inc option for asking for the data, but it should be supported.
Post NGS, thats a shame because searching for annotations has been done for some time, however there is some missing glue on the server that prevents
from working, could we at least squeeze that glue in
In fact its more complete then I realised
The url http://search.musicbrainz.org/ws/2/annotation/?query=fred works
fails ( dont know if search url should be visible to the public)
Decided to fix within 12 months by scheduling game and final decision in http://chatlogs.musicbrainz.org/musicbrainz-devel/2011/2011-12/2011-12-22.html#T22-20-32-630380
Note in the original trac ticket there was some discussion about whether this was needed but the reason it should be included is that you can do annotations lookup and searches using the website, therefore should be available in webservice as well. Search is done but needs some glue adding to mbserver, lookup is not done.
This is currently marked "In Beta Testing". Note that the ticket should remain open even if the patch currently in beta is shipped, as this got a shippit before we had a json webservice – as such, annotations currently implemented on beta are only available on the XML webservice.
Code review here http://codereview.musicbrainz.org/r/2209/ where my concern has been dismissed without any explanation or reasoning, so I repeat here with more detail.
This patch shows anotations with elements
i.e Annotation shown as part of a release
Whereas Search for same annotation
<annotation-list offset="0" count="67">
<annotation ext:score="100" type="release">
Clearly entity and name (of entity) are not required when an annotation is shown as part of a entity, whereas they are required when searching for annotations.
However Im not happy having two separate versions of annotation defined in the MMD , when they both refer to the same thing. We dont do this for any other element and defining twice as if different in MMD feels very wrong. It would be better if <entity> and <name> were just made optional and that annotation text as kept in text element. .
That is consistent, and also means we dont run into problems if at some point in the future it is decided to add another element of annotation which could certainly happen, for example http://tickets.musicbrainz.org/browse/SEARCH-230 requests that I additionally return an entity disambuguation comment to the search annotation results.
Also nothing has been checked into MMD-schema yet, released code shouldn't write ouput which dosnt match published MMD.
@Kuno please either open another ticket for that or revert this branch and ship it as a whole. This will automatically be closed when we release next week.
(Or you're welcome to re-open it).
In fact, as you haven't addressed Paul's concern, it might be best to revert this and plan it more.
Moving to 3mo as per due date
Now on beta, example urls (remove &fmt=json for XML):
NOTE to self: update webservice documentation when this ships (ticket should not be closed until documentation is updated).