[#MBS-2035] Cancelling/rejecting a medium will leave release in an unkown state - MusicBrainz JIRA

MusicBrainz Server

Cancelling/rejecting a medium will leave release in an unkown state

Created: 18/May/11 04:13 PM Updated: 02/Sep/11 05:47 AM Resolved: 22/Aug/11 10:43 AM

Component/s:

Edit system

Affects Version/s:

NGS - Final

Fix Version/s:

Bug fixes, 2011-08-22

Issue Links:

Depends

This issue is a dependency of:

MBS-3235 Allow adding release stubs (without tracklist)

Duplicate

This issue is duplicated by:

~~MBS-2388~~ Fail to add new tracklist when cancled the old one

~~MBS-2730~~ Eleanor Murray - Oh Thunder has no tracks

~~MBS-2920~~ Cannot edit a release from which I cancelled the medium adds

~~MBS-3176~~ Error when trying to add a medium to a release that has no mediums.

~~MBS-3185~~ ReleaseEditor::Edit->edit "Can't call method "add_error"

~~MBS-3206~~ Release without tracklisting causes server error

~~MBS-3222~~ Broke after pressing "Next" on the Release Information page

~~MBS-3251~~ Internal Server Error in release editor

~~MBS-3281~~ Error at switching on a tab Tracklist

~~MBS-3377~~ Release editor > ISE when editing a release with no medium

Relates

This issue has related issue:

MBS-3311 "Edits for my subscribed artists" doesn't list artists in VA-releases anymore

Resolution

This issue resolves:

~~MBS-1929~~ Release Editor: Error editing release with no existing mediums/tracklists

This issue is resolved by:

~~MBS-2232~~ Auto-approve Add Medium edits for new releases

Description

« Hide

When you add a release, separate release and mediums edits are entered. If the medium edit is cancelled or rejected the add release edit still goes through. The add release edit can also be accepted first, the medium edit can at that point still be cancelled or rejected.

Sort Order:

[ Permalink | « Hide ]

Kuno Woudt added a comment - 18/May/11 04:14 PM

I'm assigning this to the current iteration though do not expect this is an easy fix. We'll probably have to discuss with ruaok when and how we can fix this.

[ Permalink | « Hide ]

voiceinsideyou added a comment - 23/May/11 03:55 AM

luks' suggestion seems practical to me (linked ticket)

[ Permalink | « Hide ]

voiceinsideyou added a comment - 31/Jul/11 07:26 AM

Yet another example of this causing problems at ~~MBS-3123~~

[ Permalink | « Hide ]

Oliver Charles added a comment - 18/Aug/11 12:27 PM

This is now in for testing at http://test.musicbrainz.org (you cannot reject add medium edits when creating a release).

[ Permalink | « Hide ]

Johannes Weißl added a comment - 18/Aug/11 12:33 PM

Works well! And also good that the "Add release label" edit is still not an auto-edit, as I often want to vote on these edits different than on the "Add release" edit.