Issue Details (XML | Word | Printable)

Key: MBS-1989
Type: Improvement Improvement
Status: Open Open
Priority: Normal Normal
Assignee: Pavan Chander
Reporter: Pavan Chander
Votes: 4
Watchers: 3
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Make identifying add/remove/edit/merge edits easier

Created: 17/May/11 07:58 PM   Updated: 24/Feb/13 10:30 AM  Due: 05/Apr/12
Component/s: User interface - needs help
Affects Version/s: None
Fix Version/s: Within 3 months

Issue Links:
Duplicate
 


 Description  « Hide

Mixing up add and remove edits is something that frequently happens (e.g. voting incorrectly because you assumed the remove edit was actually an add edit). Using icons for these four main edits (or maybe for all of them) in addition to the text labels will make the edit queue pages easier to parse.



lidel added a comment - 04/Jun/11 11:51 AM

I think we could gain usability here by presenting the name of entity (to be removed) in "strikethrough", instead of suggested icon.


patate12 added a comment - 10/Jun/11 04:30 PM

Implementing something like this "colourful edit headers" (http://userscripts.org/scripts/show/103267) in server code for instance.


Oliver Charles made changes - 18/Nov/11 05:18 PM
Field Original Value New Value
Assignee Oliver Charles [ acid2 ]
Ian McEwen added a comment - 25/Nov/11 09:14 PM

Let me just say that I think implementing nikki's colourful edit headers userscript in code would a.) be ridiculously easy and b.) would help a lot. I think icons are a good idea as well, though, since even with the colors I often make this mistake!


patate12 added a comment - 25/Nov/11 10:03 PM

When voting I too often confuse add and remove, even with nikki's script.
So this script is a strict minimum that we should really implement. And we could go further with icons, good idea. +1


nikki added a comment - 07/Dec/11 11:03 PM

I've edited the summary to make this a bit more generic (it doesn't seem clear which solution(s) would be best right now)

more suggestions from http://bugs.musicbrainz.org/ticket/2952

Hi! I've noticed quite often I tend to read edits "in reverse". For example, I get the direction of rename edits wrong, or I confuse add with remove edits. I've noticed that with other editors, too.

Not only it's embarrassing, it can cause all sorts of unpleasant accidents, too.

I propose a couple of simple changes that should take care of this:
Write the description of all edits that remove data (ARs, URLs, releases, anything else) in bold red instead of the usual blue.
For edits that change data (titles, URLs, etc), write the "old" version of the data in strike-through, like this. (Currently that's written in the same font as the "new" data.)
Edits that add data should be left as they are now.

Someone suggested also marking delete edits with strike-through. This might be a good idea, but it might also cause confusion. Maybe red strike-through would work.

This would be done on the server, not with JavaScript, of course.


nikki made changes - 07/Dec/11 11:03 PM
Summary Use icons to identify add/remove/edit/merge edits easily Make identifying add/remove/edit/merge edits easier
patate12 added a comment - 08/Dec/11 10:18 AM

We can use the html <del>wrong info</del> and <ins>new info</ins> to style this.


Oliver Charles added a comment - 08/Dec/11 03:08 PM

We tried that before and people didn't like it.


Oliver Charles made changes - 27/Dec/11 06:37 PM
Fix Version/s Post NGS [ 10020 ]
Alex Mauer added a comment - 05/Jan/12 07:28 PM

I think this is a great idea. I have seen many mistaken votes that think a remove is an add, and comment later "whoops, sorry" ... and done a few myself.

My 2¢:

  • Don't forget that the color-blind should have this too, so that's a point towards icons
  • I don't think edits need their own icon. Only add/remove (+/-), and maybe merge.


Oliver Charles made changes - 05/Jan/12 08:04 PM
Due Date 2012-04-05 00:00:00.0
Fix Version/s Within 3 months [ 10115 ]
nikki added a comment - 06/Jan/12 08:50 AM

I'd be interested in seeing some mockups for the icons from the people who prefer that solution. I'm not really in favour of them because I can't see how they would work. It seems like they would either be too small to make a difference or too big which would make them intrusive. Only having icons for some edits seems like it wouldn't look very good either, if they're on the left, the edits wouldn't line up nicely. If they're on the right, the icons would never be in the same place.


Oliver Charles made changes - 09/Jan/12 03:15 PM
Status Open [ 1 ] Decision Required [ 10000 ]
Oliver Charles added a comment - 19/Jan/12 01:46 PM

I wonder if something like the inline labels at http://twitter.github.com/bootstrap/#typography would do the job? (search for "Inline labels"). We could have a label after the edit name, and colour code it? I understand that still doesn't solve the problem for people who are colour blind.


Ian McEwen added a comment - 23/Jul/12 02:11 PM

Assigning to Pavan re: http://chatlogs.musicbrainz.org/musicbrainz-devel/2012/2012-07/2012-07-23.html#T19-24-49-594488

Pavan: could you make us up some mockups for an idea at this using icons (and possibly colors too), so we have something real to discuss?


Ian McEwen made changes - 23/Jul/12 02:11 PM
Assignee Pavan Chander [ navap ]
Ian McEwen made changes - 23/Jul/12 02:11 PM
Status Decision Required [ 10000 ] Open [ 1 ]
nikki made changes - 24/Feb/13 10:30 AM
Link This issue is duplicated by MBS-5923 [ MBS-5923 ]