Issue Details (XML | Word | Printable)

Key: MBS-1928
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Oliver Charles
Reporter: patate12
Votes: 2
Watchers: 4
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Missing artist roles in works page

Created: 17/May/11 09:17 AM   Updated: 23/Aug/11 05:45 PM   Resolved: 22/Aug/11 07:36 PM
Component/s: Data display
Affects Version/s: None
Fix Version/s: Bug fixes, 2011-08-22

Issue Links:
Relates
 


 Description  « Hide

Works page shows what appears to be a randomly sorted artist list for each work.

Roles (lyricist, composer, arranger) are actually missing to clear up things.



Sort Order: Ascending order - Click to sort in descending order
Atedos added a comment - 17/May/11 09:26 AM

Isn't this handled via relationships?
Artis X composed Work Y would result in listing it under Composer section.


nikki added a comment - 17/May/11 09:40 AM

He means on a page like http://ngs.musicbrainz.org/artist/dc7bfdd0-886a-42a8-be7c-5ee7cf75bd22/works
There's a list of artists with nothing indicating what they did.


Christopher Key added a comment - 26/May/11 01:08 PM

The list of artist included not only with relationships to the work, but also the artists credited for any recordings related to the work, which is especially confusing. I'd suggest that in addition to adding roles after each artist related to the work, that the artists credited for related recordings get put into a separate list, even if only separated by a little vertical space.


Oliver Charles added a comment - 08/Aug/11 02:17 PM

patate12 added a comment - 08/Aug/11 02:29 PM - edited

It's great !
I have 3 remarks.

In http://test.musicbrainz.org/recording/d0a59e21-bca1-4d3d-891e-29f746cd7b6e
Beyond the Realms of Death (live) by Judas Priest is in "Perf." instead of "live perf." (OK in mb.org).

In works page now, we only see one random perf. artist instead of all of them.
http://test.musicbrainz.org/artist/88d8f38f-adb4-48a0-8c1f-ec34f2a675ff/works
Beyond the Realms of Death by 陰陽座 (current cover artist)
The Trooper by Hellsongs (another cover artist)

Perhaps it would be better to keep the unordered list with bullets, in case there are artists with long names that get word-wrapped and confused with the next artist in list.


Oliver Charles added a comment - 08/Aug/11 02:49 PM - edited

In http://test.musicbrainz.org/recording/d0a59e21-bca1-4d3d-891e-29f746cd7b6e
Beyond the Realms of Death (live) by Judas Priest is in "Perf." instead of "live perf." (OK in mb.org).

This not really a problem, it's just likely an issue that test doesn't have the same data set as musicbrainz.org

In works page now, we only see one random perf. artist instead of all of them.
http://test.musicbrainz.org/artist/88d8f38f-adb4-48a0-8c1f-ec34f2a675ff/works

Thanks for spotting this! I introduced this bug, and have quickly fixed it. If you check now you should see it will display differently.


patate12 added a comment - 08/Aug/11 03:02 PM

The jira syntax is awful with opening quote tags and... opening quote tags to close them !

Thanks for spotting this! I introduced this bug, and have quickly fixed it. If you check now you should see it will display differently.

Would it be possible to have priority to perf. before cover perf. artists in list order top ? ( I know it's a bit more feature than just this ticket but maybe it's ok timing for this)

And what do you think about bullets ?


Christopher Key added a comment - 08/Aug/11 03:39 PM

Looks good!

A couple of thoughts:

1) I might be tempted to retitle the Artist columns Performers, as I think this then makes the reason for the two columns a little clearer.

2) I might also be tempted to restrict the ARs used to populate the Artist/Performers column. To me it seems a little strange to see credits in the Artist column for, e.g. a medley AR. As an example, see:

http://test.musicbrainz.org/artist/614e3804-7d34-41ba-857f-811bad7c2b7a/works

The "Weird Al" Yankovic credit seems a little out of place.


Oliver Charles added a comment - 08/Aug/11 03:41 PM

I might be tempted to retitle the Artist columns Performers, as I think this then makes the reason for the two columns a little clearer.

I considered commenting about this on Lukas' original work, but I'm not sure it's entirely true. We extract the artists from artist credits, and do artist credits directly mean performers? For works this may be the case, but I'm not sure where style stands on this one.


patate12 added a comment - 08/Aug/11 03:49 PM - edited

2) I might also be tempted to restrict the ARs used to populate the Artist/Performers column. To me it seems a little strange to see credits in the Artist column for, e.g. a medley AR. As an example, see:

http://test.musicbrainz.org/artist/614e3804-7d34-41ba-857f-811bad7c2b7a/works

The "Weird Al" Yankovic credit seems a little out of place.

I wouldn't exclude medley, it's an equal performance (medleys can be split on some CD tracks also in which case they wouldn't be marked as medleys).


Christopher Key added a comment - 08/Aug/11 07:24 PM

I wouldn't exclude medley, it's an equal performance (medleys can be split on some CD tracks also in which case they wouldn't be marked as medleys).

Okay, I was thinking of medley as a work-work AR, not work-recording. It still looks a little odd to me, but I can see its use.


Christopher Key added a comment - 08/Aug/11 07:28 PM

> I might be tempted to retitle the Artist columns Performers, as I think this then makes the reason for the two columns a little clearer.
I considered commenting about this on Lukas' original work, but I'm not sure it's entirely true. We extract the artists from artist credits, and do artist credits directly mean performers? For works this may be the case, but I'm not sure where style stands on this one.

How about Recording Artist, perhaps paralleled by Work Artist if Writers ever become inaccurate.


patate12 added a comment - 10/Aug/11 07:53 AM

Thanks very much Oliver, the fix is really great, I love it — whatever the columns will be eventually called, I consider this fixed in a very nice way !


Oliver Charles added a comment - 10/Aug/11 12:00 PM

Most of the credit has to go to luks really, he did most of the work, I just added the parenthesis/roles.

Regarding the choice of what to display, we don't seem to be getting anywhere discussing it here, but I think we should ship in this form and if it's showing a lot of confusing information, then we can open a new ticket later.


patate12 added a comment - 23/Aug/11 05:45 PM

Thanks Luks then ! VERY MUCH !

Just a notice, when we have one song-writing artist, sometimes it's composer, lyricist and sometimes it's lyricist, composer :
http://musicbrainz.org/artist/1f245b43-f9ba-4d02-a70b-cd08a99cd1c9/works
ひまわり 浅井健一 (composer, lyricist)
フリーダム 浅井健一 (lyricist, composer)