[#MBS-1727] ModBot removes artists with pending move release group edits - MusicBrainz JIRA

MusicBrainz Server

ModBot removes artists with pending move release group edits

Created: 11/Apr/11 01:32 PM Updated: 25/Jul/12 03:50 PM Resolved: 20/Apr/11 10:28 AM

Component/s:

None

Affects Version/s:

NGS - Release Candidate 2

Fix Version/s:

NGS - Final

Issue Links:

Relates

This issue has related issue:

~~MBS-5051~~ Empty artists with pending edits still get the « will be removed automatically » warning

Description

« Hide

I added a new artist - http://test.musicbrainz.org/edit/14220995
Made an edit to move a release group to the new artist - http://test.musicbrainz.org/edit/14220996
ModBot removed the artist before the above edit could apply - http://test.musicbrainz.org/edit/14221375

same problem exists in mason code too - http://bugs.musicbrainz.org/ticket/5511

Sort Order:

[ Permalink | « Hide ]

Aurélien Mino added a comment - 11/Apr/11 02:56 PM

This is even worse: Mason looks for pending 'Move Album', 'Change Track Artist' and SAC moderations.

NGS doesn't check any pending edits,
excepted those on the artist itself (through the check on artist.edits_pending).

[ Permalink | « Hide ]

Oliver Charles added a comment - 11/Apr/11 02:59 PM

Yea, I'm thinking maybe we should just make sure that there are no edits in edit_artist that are open. Do you think this would catch all the problems?

[ Permalink | « Hide ]

Aurélien Mino added a comment - 11/Apr/11 03:06 PM

Yeah, checking open edits in edit_artist was what I was thinking about too.

It should catch all the problems, if all related edit types correctly generates entry in edit_artist.