Issue Details (XML | Word | Printable)

Key: MBS-1117
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Oliver Charles
Reporter: nikki
Votes: 2
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
MusicBrainz Server

Show relationship attributes on artist relationship pages

Created: 27/Nov/10 02:02 AM   Updated: 23/Dec/11 12:35 PM  Due: 22/Feb/12   Resolved: 23/Dec/11 12:35 PM
Component/s: Data display
Affects Version/s: NGS - Beta 3
Fix Version/s: Bug fixes, 2011-12-22

Issue Links:
Relates
 


 Description  « Hide

Currently it's possible to see all the attributes, e.g. on http://classic.musicbrainz.org/show/artist/relationships.html?artistid=491558&expanded=1&all=1 you can see that she performed vocals, background vocals and guest vocals, that she plays the erhu and that she wrote and translated lyrics, but http://musicbrainz.org/artist/dded0177-e235-474e-8529-a812b89f806c/relationships just shows the relationships without any attributes

Sort Order: Ascending order - Click to sort in descending order
Oliver Charles made changes - 06/Jan/11 01:33 PM
Field Original Value New Value
Original Estimate 45 minutes [ 2700 ]
Remaining Estimate 45 minutes [ 2700 ]
[ Permalink | « Hide ]
Paweł Paprota added a comment - 07/Jan/11 08:28 PM

I would like to work on this issue but as I'm a noob in MB server development, I have a couple of questions:

1. What is the desired way to sort link attribute types? For example, given "guest" and "instrument -> brass" attributes, old version shows "performed guest brass" but in the Link#attributes array these are reversed. Maybe I should look up the code that formatted attributes in the old version and port it here?

2. Where in the layout attributes should be displayed? I'm no usability expert so I would rather abstain from choosing the location myself. Please decide and let me know.


Paweł Paprota made changes - 07/Jan/11 08:28 PM
Assignee Oliver Charles [ acid2 ] Paweł Paprota [ ppawel ]
Paweł Paprota made changes - 07/Jan/11 08:30 PM
Status Open [ 1 ] In Progress [ 3 ]
[ Permalink | « Hide ]
Paweł Paprota added a comment - 07/Jan/11 08:33 PM

Also I think there needs to be some grouping of LinkAttributeType#children and joining them with "," or "and" - for instance, if an artist performed two instruments, the old version shows "trumpet and flugelhorn".


Paweł Paprota made changes - 08/Jan/11 05:06 PM
Status In Progress [ 3 ] Open [ 1 ]
Paweł Paprota made changes - 08/Jan/11 05:06 PM
Status Open [ 1 ] Decision Required [ 10000 ]
Oliver Charles made changes - 18/Jan/11 08:51 PM
Fix Version/s NGS - Release Candidate 2 [ 10040 ]
Fix Version/s NGS - Release Candidate 1 [ 10002 ]
Oliver Charles made changes - 21/Mar/11 08:56 PM
Fix Version/s NGS - Final [ 10050 ]
Fix Version/s NGS - Release Candidate 2 [ 10040 ]
Robert Kaye made changes - 18/May/11 02:09 AM
Fix Version/s NGS + 1 [ 10070 ]
Fix Version/s NGS - Final [ 10050 ]
voiceinsideyou made changes - 22/Aug/11 04:45 PM
Component/s Data display [ 10006 ]
voiceinsideyou made changes - 16/Sep/11 05:12 PM
Link This issue has related issue MBS-690 [ MBS-690 ]
[ Permalink | « Hide ]
Oliver Charles added a comment - 22/Nov/11 08:06 PM

Agreed to schedule within the next 3 months in this meeting: http://chatlogs.musicbrainz.org/musicbrainz-devel/2011/2011-11/2011-11-22.html#T19-31-58-896073


Oliver Charles made changes - 22/Nov/11 08:06 PM
Due Date 2012-02-22 00:00:00.0
Fix Version/s Within 3 months [ 10115 ]
Fix Version/s NGS + 1 [ 10070 ]
nikki made changes - 28/Nov/11 12:24 AM
Description Currently it's possible to see all the attributes, e.g. on http://musicbrainz.org/show/artist/relationships.html?artistid=491558&expanded=1&all=1 you can see that she performed vocals, background vocals and guest vocals, that she plays the erhu and that she wrote and translated lyrics, but http://test.musicbrainz.org/artist/dded0177-e235-474e-8529-a812b89f806c/relationships just shows the relationships without any attributes Currently it's possible to see all the attributes, e.g. on http://classic.musicbrainz.org/show/artist/relationships.html?artistid=491558&expanded=1&all=1 you can see that she performed vocals, background vocals and guest vocals, that she plays the erhu and that she wrote and translated lyrics, but http://musicbrainz.org/artist/dded0177-e235-474e-8529-a812b89f806c/relationships just shows the relationships without any attributes
Oliver Charles made changes - 15/Dec/11 02:46 PM
Status Decision Required [ 10000 ] In Progress [ 3 ]
Oliver Charles made changes - 15/Dec/11 02:46 PM
Assignee Paweł Paprota [ ppawel ] Oliver Charles [ acid2 ]
Oliver Charles made changes - 15/Dec/11 02:47 PM
Status In Progress [ 3 ] Review Submitted [ 5 ]
[ Permalink | « Hide ]
Oliver Charles added a comment - 15/Dec/11 02:47 PM

This is in review at http://codereview.musicbrainz.org/r/1660/


Oliver Charles made changes - 15/Dec/11 02:48 PM
Fix Version/s Bug fixes, 2011-12-22 [ 10122 ]
Fix Version/s Within 3 months [ 10115 ]
Oliver Charles made changes - 23/Dec/11 12:35 PM
Status Review Submitted [ 5 ] Closed [ 6 ]
Resolution Fixed [ 1 ]
Atlassian JIRA (v4.0.1#471) | Report a problem | Request a feature | Contact administrators
Powered by a free Atlassian JIRA open source license for MetaBrainz Foundation. Try JIRA - bug tracking software for your team.